[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-3.0] hw/net/dp8393x: don't make prom region

From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH for-3.0] hw/net/dp8393x: don't make prom region 'nomigrate'
Date: Mon, 9 Jul 2018 11:27:11 +0000

> Currently we use memory_region_init_rom_nomigrate() to create
> the "dp3893x-prom" memory region, and we don't manually register
> it with vmstate_register_ram(). This currently means that its
> contents are migrated but as a ram block whose name is the empty
> string; in future it may mean they are not migrated at all. Use
> memory_region_init_ram() instead.
> Note that this is a a cross-version migration compatibility break
> for the MIPS "magnum" and "pica61" machines.

As far as MIPS jazz ("magnum" and "pica61") boards are concerned:

Reviewed-by: Aleksandar Markovic <address@hidden>

> Signed-off-by: Peter Maydell <address@hidden>
> ---
> This is I think the last device that creates a RAM memory
> region and never registers it for migration.  Only used on
> the MIPS 'jazz' boards.
>  hw/net/dp8393x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]