[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0] hw/net/dp8393x: don't make prom region
Re: [Qemu-devel] [PATCH for-3.0] hw/net/dp8393x: don't make prom region 'nomigrate'
Mon, 9 Jul 2018 14:23:28 +0100
On 9 July 2018 at 12:27, Aleksandar Markovic <address@hidden> wrote:
>> Currently we use memory_region_init_rom_nomigrate() to create
>> the "dp3893x-prom" memory region, and we don't manually register
>> it with vmstate_register_ram(). This currently means that its
>> contents are migrated but as a ram block whose name is the empty
>> string; in future it may mean they are not migrated at all. Use
>> memory_region_init_ram() instead.
>> Note that this is a a cross-version migration compatibility break
>> for the MIPS "magnum" and "pica61" machines.
> As far as MIPS jazz ("magnum" and "pica61") boards are concerned:
> Reviewed-by: Aleksandar Markovic <address@hidden>
Thanks for the review. I'll put this in via target-arm.next,
just for convenience's sake, since I'm doing a pull request
this afternoon anyway.