[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial |
Date: |
Wed, 11 Jul 2018 08:53:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 10.07.2018 17:24, Peter Krempa wrote:
> On Tue, Jul 10, 2018 at 17:01:22 +0200, Cornelia Huck wrote:
>> On Tue, 10 Jul 2018 16:39:31 +0200
>> Peter Krempa <address@hidden> wrote:
>>> On Tue, Jul 10, 2018 at 16:22:08 +0200, Cornelia Huck wrote:
>>>> On Tue, 10 Jul 2018 07:59:15 +0200
>>>> Markus Armbruster <address@hidden> wrote:
>
> [...]
>
>>>> "ERROR: 'old_option' is deprecated and will be removed; use
>>>> 'modern_option' instead"
>>>>
>>>> and do an exit(1).
>>>>
>>>> Would that be workable?
>>>
>>> For delivering the warnings via monitor you'll need a store that will
>>> collect all the warnings and prepare them for delivery. You've got
>>> basically two options:
>>>
>>> 1) monitor command to poll for deprecated options
>>> 2) event with deprecated options
>>>
>>> Both require storing them since libvirt connects to the monitor only
>>> after the command line is processed.
>>>
>>> Warnings printed to stderr are nearly useless because until something
>>> breaks nobody bothers to read the log files.
>>
>> So, from that I gather that a hard failure would be the easiest for
>> libvirt to detect (and everything else would become complicated really
>> quickly), right?
>
> People start complaining only when stuff breaks. If anything is optional
> people will usually not enable it. That makes any non-mandatory option
> not work in most cases.
So would it help if we "invert" the logic, i.e. deprecated_report()
would do exit(1) by default? Then, if the (human) users still want to
continue with the deprecated option, they have to add a
"--ignore-deprecation" command line switch to make QEMU start
successfully...
Thomas
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, (continued)
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Cornelia Huck, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Kevin Wolf, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Cornelia Huck, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial,
Thomas Huth <=
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Cornelia Huck, 2018/07/11
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Krempa, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Markus Armbruster, 2018/07/12
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Kashyap Chamarthy, 2018/07/11
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Peter Maydell, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Daniel P . Berrangé, 2018/07/10
- Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial, Thomas Huth, 2018/07/09