[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-3.0 1/3] block/qapi: Add 'qdev' field to que

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-3.0 1/3] block/qapi: Add 'qdev' field to query-blockstats result
Date: Fri, 27 Jul 2018 10:07:49 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/27/2018 09:15 AM, Kevin Wolf wrote:
Like for query-block, the client needs to identify which BlockBackend
the returned data is for. Anonymous BlockBackends are identified by the
device model they are attached to. Add a 'qdev' field that contains the
qdev ID or QOM path of the attached device model.

Signed-off-by: Kevin Wolf <address@hidden>

@@ -879,7 +882,7 @@
  # Since: 0.14.0
  { 'struct': 'BlockStats',
-  'data': {'*device': 'str', '*node-name': 'str',
+  'data': {'*device': 'str', '*qdev': 'str', '*node-name': 'str',
             'stats': 'BlockDeviceStats',
             '*parent': 'BlockStats',
             '*backing': 'BlockStats'} }

Can we also update the example under query-blockstats a few lines later to show the added field?

At any rate, it looks helpful. Although this is borderline new feature, it resolves a need identified in libvirt using -blockdev, and so I can live with it as a 3.0 bugfix.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]