Re: [Qemu-devel] [PATCH v6 43/77] target/mips: Add emulation of DSP ASE for nanoMIPS - part 6

[Aleksandar Markovic]

> 
> From: Stefan Markovic <address@hidden>
> Sent: Thursday, August 2, 2018 4:16 PM
> Subject: [PATCH v6 43/77] target/mips: Add emulation of DSP ASE for nanoMIPS 
> - part 6
> 
> From: Stefan Markovic <address@hidden>
> 
> Add emulation of DSP ASE instructions for nanoMIPS - part 6.
> 
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Stefan Markovic <address@hidden>
> ---
>  target/mips/translate.c | 64 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)

> +    case NM_REPL_QB:
> +        {
> +            check_dsp(ctx);
> +            target_long result;
> +            imm = extract32(ctx->opcode, 13, 8);
> +            result = (uint32_t)imm << 24 |
> +                     (uint32_t)imm << 16 |
> +                    (uint32_t)imm << 8  |
 
Missalignment. Otherwise:

Reviewed-by: Aleksandar Markovic <address@hidden>