[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/10] spice: avoid spice runtime assert
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 04/10] spice: avoid spice runtime assert |
Date: |
Fri, 3 Aug 2018 19:36:08 +0200 |
The Spice server doesn't like to be started or stopped twice . It
aborts with:
(process:6191): Spice-ERROR **: 19:29:35.912:
red-worker.c:623:handle_dev_start: assertion `!worker->running' failed
It's easy to avoid that situation since qemu spice_display_is_running
tracks the server state.
Signed-off-by: Marc-André Lureau <address@hidden>
---
ui/spice-core.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 76896f7c7a..13f1c11b61 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -923,12 +923,20 @@ int qemu_spice_display_add_client(int csock, int
skipauth, int tls)
void qemu_spice_display_start(void)
{
+ if (spice_display_is_running) {
+ return;
+ }
+
spice_display_is_running = true;
spice_server_vm_start(spice_server);
}
void qemu_spice_display_stop(void)
{
+ if (!spice_display_is_running) {
+ return;
+ }
+
spice_server_vm_stop(spice_server);
spice_display_is_running = false;
}
--
2.18.0.547.g1d89318c48
- [Qemu-devel] [PATCH 00/10] RFC: spice: add -display app to launch external UI, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 01/10] char/spice: trigger HUP event, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 02/10] char/spice: discard write() if backend is disconnected, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 03/10] configure: bump spice-server required version to 0.12.6, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 04/10] spice: avoid spice runtime assert,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 05/10] spice: merge options lists, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 06/10] spice: do not stop spice if VM is paused, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 07/10] char: move SpiceChardev and open_spice_port() to spice.h header, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 08/10] char: register spice ports after spice started, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 09/10] build-sys: add gio-2.0 check, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 10/10] display: add -display app launching external application, Marc-André Lureau, 2018/08/03