[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/10] spice: merge options lists
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 05/10] spice: merge options lists |
Date: |
Fri, 3 Aug 2018 19:36:09 +0200 |
Passing several -spice options to qemu command line, or calling
several time qemu_opts_set() will ignore all but the first option
list. Since the spice server is a singleton, it makes sense to merge
all the options, the last value being the one taken into account.
This changes the behaviour from, for ex:
$ qemu... -spice port=5900 -spice port=5901 -> port: 5900
to:
$ qemu... -spice port=5900 -spice port=5901 -> port: 5901
(if necessary we could instead produce an error when an option is
given twice, although this makes handling default values and such more
complicated)
Signed-off-by: Marc-André Lureau <address@hidden>
---
ui/spice-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 13f1c11b61..6bd107f0f9 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -400,6 +400,7 @@ static SpiceChannelList *qmp_query_spice_channels(void)
static QemuOptsList qemu_spice_opts = {
.name = "spice",
.head = QTAILQ_HEAD_INITIALIZER(qemu_spice_opts.head),
+ .merge_lists = true,
.desc = {
{
.name = "port",
--
2.18.0.547.g1d89318c48
- [Qemu-devel] [PATCH 00/10] RFC: spice: add -display app to launch external UI, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 01/10] char/spice: trigger HUP event, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 02/10] char/spice: discard write() if backend is disconnected, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 03/10] configure: bump spice-server required version to 0.12.6, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 04/10] spice: avoid spice runtime assert, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 05/10] spice: merge options lists,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 06/10] spice: do not stop spice if VM is paused, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 07/10] char: move SpiceChardev and open_spice_port() to spice.h header, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 08/10] char: register spice ports after spice started, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 09/10] build-sys: add gio-2.0 check, Marc-André Lureau, 2018/08/03
- [Qemu-devel] [PATCH 10/10] display: add -display app launching external application, Marc-André Lureau, 2018/08/03