[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/3] intel-iommu: start to use error_report_o
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/3] intel-iommu: start to use error_report_once |
Date: |
Wed, 15 Aug 2018 20:17:21 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Wed, Aug 15, 2018 at 01:37:04PM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
>
> > Replace existing trace_vtd_err() with error_report_once() then stderr
> > will capture something if any of the error happens, meanwhile we don't
> > suffer from any DDOS. Then remove the trace point. Since at it,
> > provide more information where proper (now we can pass parameters into
> > the report function).
> >
> > Signed-off-by: Peter Xu <address@hidden>
>
> You lost
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> Happy to restore it when I apply.
I removed that since I modified the content of the patch for that
extra trace_vtd_err(). But I'd say it should be a trivial change
comparing to what this patch does, so I guess keeping Philippe's r-b
should be fine too.
(Btw, thanks for touching up again on patch 1 - I must have not
applied those whitespace changes onto my local tree and I totally
forgot it. Maybe I am spoiled when the maintainer is so nice :)
Thanks,
--
Peter Xu