[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 40/84] target/mips: Fix pre-nanoMIPS MT ASE i
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH v9 40/84] target/mips: Fix pre-nanoMIPS MT ASE instructions availability control |
Date: |
Fri, 17 Aug 2018 13:48:20 +0000 |
> > I think some of the previously-implemented similar cases involving
> > read-only bits were handled the same way, and we just built on that. What
> > would you suggest as a more appropriate solution in such cases (of
> > accessing "preset by hardware" bits)?
>
> Well, ctx->insn_flags and ctx->CP0_Config1 are good examples.
> These are 100% read-only and fixed at cpu instantiation.
>
> I see that CP0_Config3 has one writable bit for micromips, but
> is fully readonly for nanomips. Therefore XNP and MT need not
> be copied to hflags because they will never vary.
>
> I'd suggest copying CP0_Config3 to ctx as with Config1.
>
>
> r~
Hi, Richard,
The opinion within the team is that we should leave such changes for follow-up
clean-up - clean-up of CP0-related functionalities is scheduled anyway soon.
The reason is that the current implementation (in v9) works fine, and this is
very late in our dev cycle to change features with no observed bugs.
All other your concerns will be addressed in v10, which is planned to be sent
soon.
Yours,
Aleksandar
- Re: [Qemu-devel] [PATCH v9 03/84] target/mips: Avoid case statements formulated by ranges - part 2, (continued)
[Qemu-devel] [PATCH v9 19/84] target/mips: Add placeholder and invocation of decode_nanomips_opc(), Aleksandar Markovic, 2018/08/16
[Qemu-devel] [PATCH v9 25/84] target/mips: Add emulation of nanoMIPS 16-bit load and store instructions, Aleksandar Markovic, 2018/08/16
[Qemu-devel] [PATCH v9 20/84] target/mips: Add nanoMIPS decoding and extraction utilities, Aleksandar Markovic, 2018/08/16
[Qemu-devel] [PATCH v9 24/84] target/mips: Add emulation of nanoMIPS 16-bit misc instructions, Aleksandar Markovic, 2018/08/16
[Qemu-devel] [PATCH v9 26/84] target/mips: Add emulation of nanoMIPS 16-bit logic instructions, Aleksandar Markovic, 2018/08/16
[Qemu-devel] [PATCH v9 11/84] elf: Remove duplicate preprocessor constant definition, Aleksandar Markovic, 2018/08/16
[Qemu-devel] [PATCH v9 23/84] target/mips: Add emulation of nanoMIPS 16-bit shift instructions, Aleksandar Markovic, 2018/08/16
[Qemu-devel] [PATCH v9 32/84] target/mips: Add emulation of misc nanoMIPS instructions (pool32a0), Aleksandar Markovic, 2018/08/16