[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl |
Date: |
Thu, 23 Aug 2018 14:11:58 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, Aug 23, 2018 at 02:28:28PM +0800, Robert Hoo wrote:
> On Sat, 2018-08-18 at 12:05 -0300, Eduardo Habkost wrote:
[...]
> > We don't want QEMU to refuse to run if the kernel doesn't have
> > KVM_CAP_GET_MSR_FEATURES. We can treat missing capability as
> > equivalent to returning an empty list of MSRs.
> Yes. I'll let caller (kvm_arch_init) ignore the return value but a
> simple warning.
Warnings tend to be ignored and are generally a sign that QEMU
isn't doing the right thing. Sometimes we have no choice, but I
don't think that's the case here.
As far as I can see, we have only two possibilities here:
1) The host can run a VM that behaves exactly as requested on the
command-line (no warning required).
2) The host can't run the requested configuration (fatal error,
not a warning).
--
Eduardo
- Re: [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support MSR based features, (continued)
- Re: [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support MSR based features, Eduardo Habkost, 2018/08/17
- Re: [Qemu-devel] [PATCH v3 1/3] x86: Data structure changes to support MSR based features, Paolo Bonzini, 2018/08/17
- [Qemu-devel] X86CPU "feature-words" property on QEMU (was Re: [PATCH v3 1/3] x86: Data structure changes to support MSR based) features, Eduardo Habkost, 2018/08/17
- Re: [Qemu-devel] X86CPU "feature-words" property on QEMU (was Re: [PATCH v3 1/3] x86: Data structure changes to support MSR based) features, Paolo Bonzini, 2018/08/17
- Re: [Qemu-devel] X86CPU "feature-words" property on QEMU (was Re: [PATCH v3 1/3] x86: Data structure changes to support MSR based) features, Eduardo Habkost, 2018/08/17
[Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Robert Hoo, 2018/08/10
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Eduardo Habkost, 2018/08/17
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Robert Hoo, 2018/08/18
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Eduardo Habkost, 2018/08/18
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Robert Hoo, 2018/08/23
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl,
Eduardo Habkost <=
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Paolo Bonzini, 2018/08/23
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Eduardo Habkost, 2018/08/23
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Paolo Bonzini, 2018/08/23
- Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Eduardo Habkost, 2018/08/25
Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Robert Hoo, 2018/08/30
Re: [Qemu-devel] [PATCH v3 2/3] kvm: Add support to KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSRS system ioctl, Eduardo Habkost, 2018/08/30