[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 03/74] es1370: simplify MemoryRegionOps

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 03/74] es1370: simplify MemoryRegionOps
Date: Sat, 25 Aug 2018 09:48:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 24/08/2018 17:04, Peter Maydell wrote:
> because these values aren't contiguous:
> #define ES1370_REG_DAC1_FRAMEADR    0xc30
> #define ES1370_REG_DAC2_FRAMEADR    0xc38
> #define ES1370_REG_ADC_FRAMEADR     0xd30
> so you can't calculate the value of 'd' from the addr
> this way.
> (Similarly for the SCOUNT registers.)

SCOUNT is actually consecutive.  I've sent a patch for the other two.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]