[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus i
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method |
Date: |
Fri, 28 Sep 2018 15:49:56 +0100 |
On 28 September 2018 at 14:49, Cédric Le Goater <address@hidden> wrote:
> Cc: Michael Walle <address@hidden>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
> hw/net/milkymist-minimac2.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c
> index 3eaa19dfde92..5e7304a26a50 100644
> --- a/hw/net/milkymist-minimac2.c
> +++ b/hw/net/milkymist-minimac2.c
> @@ -452,9 +452,9 @@ static NetClientInfo net_milkymist_minimac2_info = {
> .receive = minimac2_rx,
> };
>
> -static int milkymist_minimac2_init(SysBusDevice *sbd)
> +static void milkymist_minimac2_realize(DeviceState *dev, Error **errp)
> {
> - DeviceState *dev = DEVICE(sbd);
> + SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
Looks like wrong indent, maybe ?
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-devel] [PATCH 02/11] net: etraxfs_eth: add a reset method, (continued)
- [Qemu-devel] [PATCH 01/11] net: etraxfs_eth: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 03/11] net: lan9118: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 05/11] net: milkymist_minimac2: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 06/11] net: mipsnet: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 07/11] net: opencores_eth: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28
- [Qemu-devel] [PATCH 08/11] net: smc91c111: convert SysBus init method to a realize method, Cédric Le Goater, 2018/09/28