[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 2/7] qapi: use qemu_strtoi64() in parse_str_int64
From: |
David Hildenbrand |
Subject: |
[Qemu-devel] [PATCH v1 2/7] qapi: use qemu_strtoi64() in parse_str_int64 |
Date: |
Tue, 9 Oct 2018 22:56:47 +0200 |
The qemu api claims to be easier to use, and the resulting code
shows that.
Signed-off-by: David Hildenbrand <address@hidden>
---
qapi/string-input-visitor.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index af0a841152..ee38ab1d10 100644
--- a/qapi/string-input-visitor.c
+++ b/qapi/string-input-visitor.c
@@ -48,10 +48,10 @@ static void free_range(void *range, void *dummy)
static int parse_str_int64(StringInputVisitor *siv, const char *name,
Error **errp)
{
- char *str = (char *) siv->string;
- long long start, end;
+ const char *str = (char *) siv->string;
+ const char *endptr;
+ int64_t start, end;
Range *cur;
- char *endptr;
if (siv->ranges) {
return 0;
@@ -62,9 +62,7 @@ static int parse_str_int64(StringInputVisitor *siv, const
char *name,
}
do {
- errno = 0;
- start = strtoll(str, &endptr, 0);
- if (errno == 0 && endptr > str) {
+ if (!qemu_strtoi64(str, &endptr, 0, &start)) {
if (*endptr == '\0') {
cur = g_malloc0(sizeof(*cur));
range_set_bounds(cur, start, start);
@@ -73,11 +71,7 @@ static int parse_str_int64(StringInputVisitor *siv, const
char *name,
str = NULL;
} else if (*endptr == '-') {
str = endptr + 1;
- errno = 0;
- end = strtoll(str, &endptr, 0);
- if (errno == 0 && endptr > str && start <= end &&
- (start > INT64_MAX - 65536 ||
- end < start + 65536)) {
+ if (!qemu_strtoi64(str, &endptr, 0, &end) && start < end) {
if (*endptr == '\0') {
cur = g_malloc0(sizeof(*cur));
range_set_bounds(cur, start, end);
--
2.17.1
- [Qemu-devel] [PATCH v1 0/7] qapi/range/memory-device: fixes and cleanups, David Hildenbrand, 2018/10/09
- [Qemu-devel] [PATCH v1 1/7] qapi: correctly parse uint64_t values from strings, David Hildenbrand, 2018/10/09
- [Qemu-devel] [PATCH v1 2/7] qapi: use qemu_strtoi64() in parse_str_int64,
David Hildenbrand <=
- [Qemu-devel] [PATCH v1 3/7] range: pass const pointer where possible, David Hildenbrand, 2018/10/09
- [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/09
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, Dr. David Alan Gilbert, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, Dr. David Alan Gilbert, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, Dr. David Alan Gilbert, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/11
[Qemu-devel] [PATCH v1 7/7] memory-device: rewrite address assignment using ranges, David Hildenbrand, 2018/10/09