[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 3/7] range: pass const pointer where possible
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v1 3/7] range: pass const pointer where possible |
Date: |
Thu, 11 Oct 2018 09:39:55 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* David Hildenbrand (address@hidden) wrote:
> If there are no changes, let's use a const pointer.
>
> Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> include/qemu/range.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/qemu/range.h b/include/qemu/range.h
> index f28f0c1825..7e75f4e655 100644
> --- a/include/qemu/range.h
> +++ b/include/qemu/range.h
> @@ -39,7 +39,7 @@ struct Range {
> uint64_t upb; /* inclusive upper bound */
> };
>
> -static inline void range_invariant(Range *range)
> +static inline void range_invariant(const Range *range)
> {
> assert(range->lob <= range->upb || range->lob == range->upb + 1);
> }
> @@ -48,14 +48,14 @@ static inline void range_invariant(Range *range)
> #define range_empty ((Range){ .lob = 1, .upb = 0 })
>
> /* Is @range empty? */
> -static inline bool range_is_empty(Range *range)
> +static inline bool range_is_empty(const Range *range)
> {
> range_invariant(range);
> return range->lob > range->upb;
> }
>
> /* Does @range contain @val? */
> -static inline bool range_contains(Range *range, uint64_t val)
> +static inline bool range_contains(const Range *range, uint64_t val)
> {
> return val >= range->lob && val <= range->upb;
> }
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v1 0/7] qapi/range/memory-device: fixes and cleanups, David Hildenbrand, 2018/10/09
- [Qemu-devel] [PATCH v1 1/7] qapi: correctly parse uint64_t values from strings, David Hildenbrand, 2018/10/09
- [Qemu-devel] [PATCH v1 2/7] qapi: use qemu_strtoi64() in parse_str_int64, David Hildenbrand, 2018/10/09
- [Qemu-devel] [PATCH v1 3/7] range: pass const pointer where possible, David Hildenbrand, 2018/10/09
- Re: [Qemu-devel] [PATCH v1 3/7] range: pass const pointer where possible,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/09
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, Dr. David Alan Gilbert, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, Dr. David Alan Gilbert, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, Dr. David Alan Gilbert, 2018/10/11
- Re: [Qemu-devel] [PATCH v1 4/7] range: add some more functions, David Hildenbrand, 2018/10/11
[Qemu-devel] [PATCH v1 7/7] memory-device: rewrite address assignment using ranges, David Hildenbrand, 2018/10/09