[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] show-fixed-bugs.sh: Modern shell scripting
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] show-fixed-bugs.sh: Modern shell scripting (use $() instead of ``) |
Date: |
Mon, 15 Oct 2018 09:12:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-10-15 08:51, Mao Zhongyi wrote:
> Various shell files contain a mix between obsolete `` and
> modern $(); use of `` is only required when using /bin/sh
> on Solaris. It would be nice to convert to using $()
> everywhere, or at least in all bash scripts, as well as in
> all scripts that are known to not be run on Solaris.
>
> Signed-off-by: Mao Zhongyi <address@hidden>
> ---
> scripts/show-fixed-bugs.sh | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/show-fixed-bugs.sh b/scripts/show-fixed-bugs.sh
> index 36f306898f..a095a4d6ba 100755
> --- a/scripts/show-fixed-bugs.sh
> +++ b/scripts/show-fixed-bugs.sh
> @@ -23,10 +23,10 @@ while getopts "s:e:cbh" opt; do
> done
>
> if [ "x$start" = "x" ]; then
> - start=`git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1`
> + start=$(git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 2 | head -n 1)
> fi
> if [ "x$end" = "x" ]; then
> - end=`git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 1`
> + end=$(git tag -l 'v[0-9]*\.[0-9]*\.0' | tail -n 1)
> fi
>
> if [ "x$start" = "x" ] || [ "x$end" = "x" ]; then
> @@ -38,9 +38,9 @@ fi
> echo "Searching git log for bugs in the range $start..$end"
>
> urlstr='https://bugs.launchpad.net/\(bugs\|qemu/+bug\)/'
> -bug_urls=`git log $start..$end \
> +bug_urls=$(git log $start..$end \
> | sed -n '\,'"$urlstr"', s,\(.*\)\('"$urlstr"'\)\([0-9]*\).*,\2\4,p' \
> - | sort -u`
> + | sort -u)
>
> echo Found bug URLs:
> for i in $bug_urls ; do echo " $i" ; done
> @@ -68,7 +68,7 @@ elif [ "x$show_in_browser" = "x1" ]; then
> bugbrowser=xdg-open
> elif command -v gnome-open >/dev/null 2>&1; then
> bugbrowser=gnome-open
> - elif [ "`uname`" = "Darwin" ]; then
> + elif [ "$(uname)" = "Darwin" ]; then
> bugbrowser=open
> elif command -v sensible-browser >/dev/null 2>&1; then
> bugbrowser=sensible-browser
>
Reviewed-by: Thomas Huth <address@hidden>