[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 10/71] hppa: convert to helper_cpu_halted_set
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [RFC v4 10/71] hppa: convert to helper_cpu_halted_set |
Date: |
Wed, 31 Oct 2018 11:43:05 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Emilio G. Cota <address@hidden> writes:
> Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/hppa/translate.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index ce05d5619d..df9179e70f 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -2845,8 +2845,7 @@ static DisasJumpType trans_pause(DisasContext *ctx,
> uint32_t insn,
>
> /* Tell the qemu main loop to halt until this cpu has work. */
> tmp = tcg_const_i32(1);
> - tcg_gen_st_i32(tmp, cpu_env, -offsetof(HPPACPU, env) +
> - offsetof(CPUState, halted));
> + gen_helper_cpu_halted_set(cpu_env, tmp);
> tcg_temp_free_i32(tmp);
> gen_excp_1(EXCP_HALTED);
--
Alex Bennée
- Re: [Qemu-devel] [RFC v4 02/71] cpu: rename cpu->work_mutex to cpu->lock, (continued)
- [Qemu-devel] [RFC v4 39/71] i386/hax-all: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 06/71] cpu: introduce process_queued_cpu_work_locked, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 03/71] cpu: introduce cpu_mutex_lock/unlock, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 10/71] hppa: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 14/71] cpu: define cpu_halted helpers, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 38/71] i386/kvm: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 22/71] mips: convert to cpu_halted, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 23/71] riscv: convert to cpu_halted, Emilio G. Cota, 2018/10/25