[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set |
Date: |
Wed, 31 Oct 2018 11:45:58 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Emilio G. Cota <address@hidden> writes:
> Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target/alpha/translate.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/target/alpha/translate.c b/target/alpha/translate.c
> index e5d62850c5..25cd95931d 100644
> --- a/target/alpha/translate.c
> +++ b/target/alpha/translate.c
> @@ -1226,8 +1226,7 @@ static DisasJumpType gen_call_pal(DisasContext *ctx,
> int palcode)
> /* WTINT */
> {
> TCGv_i32 tmp = tcg_const_i32(1);
> - tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) +
> - offsetof(CPUState, halted));
> + gen_helper_cpu_halted_set(cpu_env, tmp);
> tcg_temp_free_i32(tmp);
> }
> tcg_gen_movi_i64(ctx->ir[IR_V0], 0);
> @@ -1382,8 +1381,7 @@ static DisasJumpType gen_mtpr(DisasContext *ctx, TCGv
> vb, int regno)
> /* WAIT */
> {
> TCGv_i32 tmp = tcg_const_i32(1);
> - tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) +
> - offsetof(CPUState, halted));
> + gen_helper_cpu_halted_set(cpu_env, tmp);
> tcg_temp_free_i32(tmp);
> }
> return gen_excp(ctx, EXCP_HALTED, 0);
--
Alex Bennée
- [Qemu-devel] [RFC v4 03/71] cpu: introduce cpu_mutex_lock/unlock, (continued)
- [Qemu-devel] [RFC v4 03/71] cpu: introduce cpu_mutex_lock/unlock, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 10/71] hppa: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 14/71] cpu: define cpu_halted helpers, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 12/71] alpha: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 38/71] i386/kvm: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 22/71] mips: convert to cpu_halted, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 23/71] riscv: convert to cpu_halted, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 20/71] lm32: convert to cpu_halted, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 11/71] m68k: convert to helper_cpu_halted_set, Emilio G. Cota, 2018/10/25