[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/10] cputlb: Remove tlb_c.pending_flushes
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 10/10] cputlb: Remove tlb_c.pending_flushes |
Date: |
Wed, 31 Oct 2018 12:21:19 +0000 |
This is essentially redundant with tlb_c.dirty.
Tested-by: Emilio G. Cota <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
include/exec/cpu-defs.h | 6 ------
accel/tcg/cputlb.c | 16 ++--------------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index ca0fea8b27..6a60f94a41 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -160,12 +160,6 @@ typedef struct CPUTLBDesc {
typedef struct CPUTLBCommon {
/* Serialize updates to tlb_table and tlb_v_table, and others as noted. */
QemuSpin lock;
- /*
- * Within pending_flush, for each bit N, there exists an outstanding
- * cross-cpu flush for mmu_idx N. Further cross-cpu flushes to that
- * mmu_idx may be discarded. Protected by tlb_c.lock.
- */
- uint16_t pending_flush;
/*
* Within dirty, for each bit N, modifications have been made to
* mmu_idx N since the last time that mmu_idx was flushed.
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index f6c37bc4db..af6bd8ccf9 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -174,20 +174,8 @@ void tlb_flush_by_mmuidx(CPUState *cpu, uint16_t idxmap)
tlb_debug("mmu_idx: 0x%" PRIx16 "\n", idxmap);
if (cpu->created && !qemu_cpu_is_self(cpu)) {
- CPUArchState *env = cpu->env_ptr;
- uint16_t pending, to_clean;
-
- qemu_spin_lock(&env->tlb_c.lock);
- pending = env->tlb_c.pending_flush;
- to_clean = idxmap & ~pending;
- env->tlb_c.pending_flush = pending | idxmap;
- qemu_spin_unlock(&env->tlb_c.lock);
-
- if (to_clean) {
- tlb_debug("reduced mmu_idx: 0x%" PRIx16 "\n", to_clean);
- async_run_on_cpu(cpu, tlb_flush_by_mmuidx_async_work,
- RUN_ON_CPU_HOST_INT(to_clean));
- }
+ async_run_on_cpu(cpu, tlb_flush_by_mmuidx_async_work,
+ RUN_ON_CPU_HOST_INT(idxmap));
} else {
tlb_flush_by_mmuidx_async_work(cpu, RUN_ON_CPU_HOST_INT(idxmap));
}
--
2.17.2
- [Qemu-devel] [PULL 00/10] cputlb: track dirty tlbs and general cleanup, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 01/10] cputlb: Move tlb_lock to CPUTLBCommon, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 02/10] cputlb: Remove tcg_enabled hack from tlb_flush_nocheck, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 03/10] cputlb: Move cpu->pending_tlb_flush to env->tlb_c.pending_flush, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 07/10] cputlb: Merge tlb_flush_page into tlb_flush_page_by_mmuidx, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 06/10] cputlb: Merge tlb_flush_nocheck into tlb_flush_by_mmuidx_async_work, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 09/10] cputlb: Filter flushes on already clean tlbs, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 04/10] cputlb: Split large page tracking per mmu_idx, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 08/10] cputlb: Count "partial" and "elided" tlb flushes, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 05/10] cputlb: Move env->vtlb_index to env->tlb_d.vindex, Richard Henderson, 2018/10/31
- [Qemu-devel] [PULL 10/10] cputlb: Remove tlb_c.pending_flushes,
Richard Henderson <=