[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [for-4.0 PATCH v3.1 8/9] q35/440fx/arm/spapr/ccw: Add Q

From: Peter Maydell
Subject: Re: [Qemu-devel] [for-4.0 PATCH v3.1 8/9] q35/440fx/arm/spapr/ccw: Add QEMU 4.0 machine type
Date: Tue, 4 Dec 2018 19:29:25 +0000

On Tue, 4 Dec 2018 at 19:26, Alex Williamson <address@hidden> wrote:
> On Tue, 4 Dec 2018 20:16:44 +0100
> Christian Borntraeger <address@hidden> wrote:
> > I think Conny has already added the s390/ccw part to her next tree.
> > From a quick glimpse both patches look identical.
> If so then we can just use the original v3 version of this patch that
> touches all but ccw and let them come together in mainline.  My
> assumption is that Peter is only trying to make sure all versioned
> machines are updated early in this release, not necessarily that
> they need to be updated together.

Yes, that's the idea. I also think it's a suboptimal idea
to include the version-number-bump patch in a series that's
adding some feature, because then if the feature itself
has to go through several rounds of patch review the
version-number-bump patch is stuck unapplied (we saw that
at the end of the 3.1 cycle), or it gets bumped by some
other unrelated series and then there's a merge conflict.
But that's more of a things-for-next time remark, no need
to rearrange this now.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]