[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch conte
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context |
Date: |
Thu, 6 Dec 2018 00:37:35 +0400 |
COLO uses a worker context (iothread) to drive the chardev. All
backends are not able to switch the context, let's report an error in
this case.
Signed-off-by: Marc-André Lureau <address@hidden>
---
net/colo-compare.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index a39191d522..9156ab3349 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -957,6 +957,12 @@ static int find_and_check_chardev(Chardev **chr,
return 1;
}
+ if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
+ error_setg(errp, "chardev \"%s\" cannot switch context",
+ chr_name);
+ return 1;
+ }
+
return 0;
}
--
2.20.0.rc1
- Re: [Qemu-devel] [PATCH for-4.0 v4 3/7] char: add a QEMU_CHAR_FEATURE_GCONTEXT flag, (continued)
- [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/05
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Marc-André Lureau, 2018/12/06
- Re: [Qemu-devel] [PATCH for-4.0 v4 4/7] monitor: check if chardev can switch gcontext for OOB, Markus Armbruster, 2018/12/06
[Qemu-devel] [PATCH for-4.0 v4 5/7] colo: check chardev can switch context,
Marc-André Lureau <=
[Qemu-devel] [PATCH for-4.0 v4 6/7] monitor: prevent inserting new monitors after cleanup, Marc-André Lureau, 2018/12/05
[Qemu-devel] [PATCH for-4.0 v4 7/7] monitor: avoid potential dead-lock when cleaning up, Marc-André Lureau, 2018/12/05
Re: [Qemu-devel] [PATCH for-4.0 v4 0/7] monitor: misc fixes, Markus Armbruster, 2018/12/06