[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/6] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' comm

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 5/6] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command
Date: Fri, 7 Dec 2018 11:26:30 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/7/18 11:03 AM, Philippe Mathieu-Daudé wrote:
$ qemu-system-x86_64 -S -monitor stdio
(qemu) info fw_cfg
         Type    Perm    Size    Specific   Order   Info
    signature      RO       4                       QEMU
           id      RO       4                       0x00000003
         uuid      RO      16                       
     ram_size      RO       8                       0x0000000008000000
    nographic      RO       2                       0x0000
      nb_cpus      RO       2                       0x0001
         numa      RO      16
    boot_menu      RO       2                       0x0000
     max_cpus      RO       2                       0x0001
     file_dir      RO    2052
  file (id 1)      RO      36                 160   etc/acpi/rsdp
  file (id 2)      RO  131072                 130   etc/acpi/tables
  file (id 3)      RO       4                  15   etc/boot-fail-wait
  file (id 4)      RO      20                  40   etc/e820
  file (id 5)      RO      31                  30   etc/smbios/smbios-anchor
  file (id 6)      RO     320                  20   etc/smbios/smbios-tables
  file (id 7)      RO       6                  90   etc/system-states
  file (id 8)      RO    4096                 140   etc/table-loader
file (id 10)      RO    9216                  55   genroms/kvmvapic.bin
         uuid      RO       4  (arch spec)          
     ram_size      RO     324  (arch spec)
    nographic      RO     121  (arch spec)

In general, when adding something to HMP but not QMP, it is worth a comment explaining WHY we did not want QMP. (Here, I think the reason is that this is a debugging aid likely to be useful to developers but unlikely to be needed by a management app, and matches similar other HMP-only info commands, and is therefore not worth the effort of turning it into QAPI).

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]