[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] hw/i386: Remove unused include
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] hw/i386: Remove unused include |
Date: |
Fri, 7 Dec 2018 12:43:18 -0500 |
On Fri, Dec 07, 2018 at 06:03:57PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/acpi/piix4.c | 1 -
> hw/i386/acpi-build.c | 1 -
> hw/i386/pc.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
> index e330f24c71..49a33bfcda 100644
> --- a/hw/acpi/piix4.c
> +++ b/hw/acpi/piix4.c
> @@ -28,7 +28,6 @@
> #include "sysemu/sysemu.h"
> #include "qapi/error.h"
> #include "qemu/range.h"
> -#include "hw/nvram/fw_cfg.h"
> #include "exec/address-spaces.h"
> #include "hw/acpi/piix4.h"
> #include "hw/acpi/pcihp.h"
Looks right.
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 236a20eaa8..1e5c371294 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -35,7 +35,6 @@
> #include "hw/acpi/acpi-defs.h"
> #include "hw/acpi/acpi.h"
> #include "hw/acpi/cpu.h"
> -#include "hw/nvram/fw_cfg.h"
> #include "hw/acpi/bios-linker-loader.h"
> #include "hw/loader.h"
> #include "hw/isa/isa.h"
This one calls fw_cfg_add_file.
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index f095725dba..2221dcdb36 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -35,7 +35,6 @@
> #include "hw/ide.h"
> #include "hw/pci/pci.h"
> #include "hw/pci/pci_bus.h"
> -#include "hw/nvram/fw_cfg.h"
> #include "hw/timer/hpet.h"
> #include "hw/smbios/smbios.h"
> #include "hw/loader.h"
And this calls fw_cfg_add_bytes
> --
> 2.17.2
- [Qemu-devel] [PATCH 0/6] fw_cfg: add HMP 'info fw_cfg' and add_file_from_host(), Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 1/6] hw/arm/virt: Remove null-check in virt_build_smbios(), Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 2/6] hw/arm: Remove unused include, Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 3/6] hw/i386: Remove unused include, Philippe Mathieu-Daudé, 2018/12/07
- Re: [Qemu-devel] [PATCH 3/6] hw/i386: Remove unused include,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH 4/6] hw/nvram/fw_cfg: Add trace events, Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 6/6] hw/nvram/fw_cfg: Add fw_cfg_add_file_from_host(), Philippe Mathieu-Daudé, 2018/12/07
- [Qemu-devel] [PATCH 5/6] hw/nvram/fw_cfg: Add HMP 'info fw_cfg' command, Philippe Mathieu-Daudé, 2018/12/07