[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode |
Date: |
Mon, 14 Jan 2019 15:53:48 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-14 15:50, Eric Blake wrote:
> On 1/14/19 8:31 AM, Daniel P. Berrangé wrote:
>
>>>
>>> Can we suppress the warnings with #pragma instead ?
>>> That would avoid compiling the .o file with different
>>> C semantics.
>>
>> IIUC this is a built-in warning you can't disable, except by changing
>> the compilation mode to have gnu89 inline semantics :-(
>
> Could we instead fix the warning by one of:
>
> Using pragma to declare the header as a system header (used to silence
> warnings from misbehaving external headers),
How do you do that?
> and/or adding #defines around the inclusion of the header to neutralize
> the poor warnings,
You mean something like:
#define inline /* nothing */
?
... sounds quite ugly to me, too.
> but without changing the compilation mode of the
> entire project
The patch is only changing libiscsi_cflags, so it's not affecting the
entire project, but just the files that use libiscsi.
Thomas
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Thomas Huth, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Peter Maydell, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Daniel P . Berrangé, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Thomas Huth, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Eric Blake, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Eric Blake, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Thomas Huth, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Thomas Huth, 2019/01/14
- Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Daniel P . Berrangé, 2019/01/14
Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode, Philippe Mathieu-Daudé, 2019/01/14