[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kco
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kconfig |
Date: |
Thu, 17 Jan 2019 11:25:39 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2019-01-15 15:10, Yang Zhong wrote:
> From: Paolo Bonzini <address@hidden>
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Yang Zhong <address@hidden>
> ---
> default-configs/i386-softmmu.mak | 10 ----------
> hw/audio/Kconfig | 2 ++
> hw/block/Kconfig | 2 ++
> hw/char/Kconfig | 6 ++++++
> hw/display/Kconfig | 6 ++++++
> hw/i386/Kconfig | 1 +
> hw/ide/Kconfig | 1 +
> hw/input/Kconfig | 2 ++
> hw/isa/Kconfig | 5 +++++
> hw/misc/Kconfig | 4 ++++
> hw/net/Kconfig | 3 +++
> hw/watchdog/Kconfig | 2 ++
> 12 files changed, 34 insertions(+), 10 deletions(-)
[...]
> diff --git a/hw/display/Kconfig b/hw/display/Kconfig
> index 5e73277cc2..a53ca4601a 100644
> --- a/hw/display/Kconfig
> +++ b/hw/display/Kconfig
> @@ -9,6 +9,9 @@ config ADS7846
>
> config VGA_CIRRUS
> bool
> + default y
> + depends on PCI
> + select VGA
This hunk should likely rather be part of the pci.mak patch?
Apart from that, the patch here looks fine to me.
Thomas
- [Qemu-devel] [RFC PATCH v2 27/37] bluetooth: express dependencies with Kconfig, (continued)
- [Qemu-devel] [RFC PATCH v2 27/37] bluetooth: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 36/37] minikconf: implement allyesconfig, allnoconfig, randconfig, defconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 35/37] i386-softmmu.mak: remove all CONFIG_* except boards definitions, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 33/37] hyperv: express dependencies with kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 32/37] edid: express dependencies with kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 31/37] ptimer: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kconfig, Yang Zhong, 2019/01/15
- Re: [Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kconfig,
Thomas Huth <=
- [Qemu-devel] [RFC PATCH v2 29/37] i386: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 25/37] build: convert usb.mak to Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 26/37] scsi: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 24/37] build: convert sound.mak to Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 17/37] minikconfig: add semantic analysis, Yang Zhong, 2019/01/15