[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 24/37] build: convert sound.mak to Kconfi
From: |
Yang Zhong |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 24/37] build: convert sound.mak to Kconfig |
Date: |
Fri, 18 Jan 2019 15:24:43 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 16, 2019 at 02:51:37PM +0100, Thomas Huth wrote:
> On 2019-01-16 14:48, Thomas Huth wrote:
> > On 2019-01-15 15:10, Yang Zhong wrote:
> >> From: Paolo Bonzini <address@hidden>
> >>
> >> There is really nothing special in these devices; they are just
> >> ISA devices. Instead of including them for each target,
> >> set CONFIG_ISA to true, and make the devices default to present
> >> whenever ISA is available. More conversion of ISA devices will
> >> follow.
> > [...]
> >> diff --git a/default-configs/ppc-softmmu.mak
> >> b/default-configs/ppc-softmmu.mak
> >> index 301cc83279..c7003e4284 100644
> >> --- a/default-configs/ppc-softmmu.mak
> >> +++ b/default-configs/ppc-softmmu.mak
> >> @@ -1,8 +1,8 @@
> >> # Default configuration for ppc-softmmu
> >>
> >> -include sound.mak
> >> include usb.mak
> >> CONFIG_PCI=y
> >> +ONFIG_ISA=y
> >
> > Typo: CONFIG_ISA please
>
> Or should it even be CONFIG_ISA_BUS ? At least that's the name of the
> switch that you use in the other patches ...
>
Hello Thomas,
Yes, We should change this to CONFIG_ISA_BUS here and the patch's
description will be changed correspondingly.
Regards,
Yang
> Thomas
- [Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kconfig, (continued)
- [Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 29/37] i386: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 25/37] build: convert usb.mak to Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 26/37] scsi: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 24/37] build: convert sound.mak to Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 17/37] minikconfig: add semantic analysis, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 21/37] ide: express dependencies with Kconfig, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 11/37] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally, Yang Zhong, 2019/01/15
- [Qemu-devel] [RFC PATCH v2 19/37] kconfig: introduce kconfig files, Yang Zhong, 2019/01/15