Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

[Paolo Bonzini]

On 17/01/19 17:13, Stefano Garzarella wrote:
> On Thu, Jan 17, 2019 at 04:18:00PM +0100, Paolo Bonzini wrote:
>> On 17/01/19 16:05, Stefano Garzarella wrote:
>>>> That's part of what I didn't quite understand.
>>>> pc-bios/optionrom/linuxboot.bin (and the other binaries in the 'build-all'
>>>> target in pc-bios/optionrom/Makefile) are in .gitignore.
>>>>
>>>> Also, should pvh.bin be added to BLOBS in Makefile like those files?
>>> Yes, indeed I added pvh.bin to BLOBS in patch 3/5 and I committed the
>>> binary file in /pc-bios/ (note: not in /pc-bios/optionrom/ where it is
>>> compiled, maybe is here the confusion, but I following what was done for
>>> the other option roms)
>>
>> Nevermind---I was totally sure .bin files are committed.  Though perhaps
>> they should, since non-x86 binaries are.
> 
> They are committed (in /pc-bios/) but not were they are compiled
> (in /pc-bios/optionrom/).

Oh, I see.  Sorry if I'm so dumb sometimes...

Paolo