[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg
From: |
Stefano Garzarella |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg |
Date: |
Thu, 17 Jan 2019 16:05:15 +0100 |
User-agent: |
NeoMutt/20180716 |
On Thu, Jan 17, 2019 at 02:52:25PM +0000, Liam Merwick wrote:
>
>
> On 17/01/2019 14:37, Paolo Bonzini wrote:
> > On 17/01/19 15:33, Liam Merwick wrote:
> > > # pc-bios/optionrom/pvh.bin
> > > # pc-bios/optionrom/pvh.img
> > > # pc-bios/optionrom/pvh.raw
> >
> > pvh.bin should not be ignored.
> >
>
> That's part of what I didn't quite understand.
> pc-bios/optionrom/linuxboot.bin (and the other binaries in the 'build-all'
> target in pc-bios/optionrom/Makefile) are in .gitignore.
>
> Also, should pvh.bin be added to BLOBS in Makefile like those files?
Yes, indeed I added pvh.bin to BLOBS in patch 3/5 and I committed the
binary file in /pc-bios/ (note: not in /pc-bios/optionrom/ where it is
compiled, maybe is here the confusion, but I following what was done for
the other option roms)
Of course, I forgot to add the pc-bios/optionrom/pvh.* entries in
.gitignore :)
Thanks,
Stefano
- [Qemu-devel] [PATCH v4 1/5] linuxboot_dma: remove duplicate definitions of FW_CFG, (continued)
- [Qemu-devel] [PATCH v4 1/5] linuxboot_dma: remove duplicate definitions of FW_CFG, Stefano Garzarella, 2019/01/17
- [Qemu-devel] [PATCH v4 2/5] linuxboot_dma: move common functions in a new header, Stefano Garzarella, 2019/01/17
- [Qemu-devel] [PATCH v4 4/5] hw/i386/pc: use PVH option rom, Stefano Garzarella, 2019/01/17
- [Qemu-devel] [PATCH v4 3/5] optionrom: add new PVH option rom, Stefano Garzarella, 2019/01/17
- [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Stefano Garzarella, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Stefan Hajnoczi, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Liam Merwick, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Paolo Bonzini, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Stefano Garzarella, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Liam Merwick, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg,
Stefano Garzarella <=
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Paolo Bonzini, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Stefano Garzarella, 2019/01/17
- Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg, Paolo Bonzini, 2019/01/17