[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie co
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable |
Date: |
Fri, 18 Jan 2019 11:33:05 -0500 |
On Fri, Jan 18, 2019 at 07:23:55PM +0800, Yang Zhong wrote:
> Make pcie splited from pci and make it configurable.
>
> Signed-off-by: Yang Zhong <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> ---
> default-configs/pci.mak | 1 +
> hw/pci/Kconfig | 3 +++
> hw/pci/Makefile.objs | 5 +++--
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> index c1b64922b9..553b1905de 100644
> --- a/default-configs/pci.mak
> +++ b/default-configs/pci.mak
> @@ -1,4 +1,5 @@
> CONFIG_PCI=y
> +CONFIG_PCIE=y
> # For now, CONFIG_IDE_CORE requires ISA, so we enable it here
> CONFIG_ISA_BUS=y
> CONFIG_VIRTIO_PCI=y
> diff --git a/hw/pci/Kconfig b/hw/pci/Kconfig
> index d3d2205577..a717a26995 100644
> --- a/hw/pci/Kconfig
> +++ b/hw/pci/Kconfig
> @@ -1,2 +1,5 @@
> config PCI
> bool
> +
> +config PCIE
> + bool
I think PCIE should depend on PCI or something like this.
That's because there are places in code that test CONFIG_PCI,
you want PCIE to enable them as well.
> diff --git a/hw/pci/Makefile.objs b/hw/pci/Makefile.objs
> index 9f905e6344..a995795a47 100644
> --- a/hw/pci/Makefile.objs
> +++ b/hw/pci/Makefile.objs
> @@ -2,8 +2,9 @@ common-obj-$(CONFIG_PCI) += pci.o pci_bridge.o
> common-obj-$(CONFIG_PCI) += msix.o msi.o
> common-obj-$(CONFIG_PCI) += shpc.o
> common-obj-$(CONFIG_PCI) += slotid_cap.o
> -common-obj-$(CONFIG_PCI) += pci_host.o pcie_host.o
> -common-obj-$(CONFIG_PCI) += pcie.o pcie_aer.o pcie_port.o
> +common-obj-$(CONFIG_PCI) += pci_host.o
> +common-obj-$(CONFIG_PCIE) += pcie.o pcie_aer.o
> +common-obj-$(CONFIG_PCIE) += pcie_port.o pcie_host.o
>
> common-obj-$(call lnot,$(CONFIG_PCI)) += pci-stub.o
> common-obj-$(CONFIG_ALL) += pci-stub.o
> --
> 2.17.1
>
- [Qemu-devel] [RFC PATCH v3 17/43] hw/hppa/Makefile.objs: Create CONFIG_* for hppa, (continued)
- [Qemu-devel] [RFC PATCH v3 17/43] hw/hppa/Makefile.objs: Create CONFIG_* for hppa, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 21/43] minikconfig: add parser skeleton, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 19/43] hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 20/43] hw/tricore/Makefile.objs: Create CONFIG_* for tricore, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 22/43] minikconfig: add AST, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 27/43] ide: express dependencies with Kconfig, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 24/43] hw/display: make edid configurable, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 23/43] minikconfig: add semantic analysis, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 26/43] build: switch to Kconfig, Yang Zhong, 2019/01/18
- [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable, Yang Zhong, 2019/01/18
- Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable, Paolo Bonzini, 2019/01/18
- Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable, Michael S. Tsirkin, 2019/01/18
- Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable, Paolo Bonzini, 2019/01/21
- Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable, Yang Zhong, 2019/01/21
- Re: [Qemu-devel] [RFC PATCH v3 28/43] hw/pci/Makefile.objs: make pcie configurable, Paolo Bonzini, 2019/01/21
[Qemu-devel] [RFC PATCH v3 25/43] kconfig: introduce kconfig files, Yang Zhong, 2019/01/18
[Qemu-devel] [RFC PATCH v3 30/43] build: convert sound.mak to Kconfig, Yang Zhong, 2019/01/18
[Qemu-devel] [RFC PATCH v3 31/43] build: convert usb.mak to Kconfig, Yang Zhong, 2019/01/18
[Qemu-devel] [RFC PATCH v3 29/43] build: convert pci.mak to Kconfig, Yang Zhong, 2019/01/18