[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage |
Date: |
Fri, 25 Jan 2019 07:57:43 +0100 |
User-agent: |
NeoMutt/20180716 |
On Thu, Jan 24, 2019 at 09:12:58PM +0100, Zoltán Kővágó wrote:
> On 2019-01-24 12:19, Gerd Hoffmann wrote:
> > Hi,
> >
> >> So, I think with the first part the only open issue is whenever we go
> >> with the nested types (i.e. patch #1 as-is) or not. Given that the
> >> one-element-structs added in that patch will get additional fields I
> >> think the nesting makes sense.
> >
> > Spoke too soon: scripts/checkpatch.pl flags a bunch of codestyle issues.
>
> Most of them are about the code style of the old audio subsystem, I
> fixed some of them but not everything. IIRC last time it wasn't a
> problem, but it was in 2015. Should I go over them again and fix all of
> them?
The first ones I saw where not a old audio codestyle (which is
whitespace-after-function-name mostly) issues but newly introduced ones.
A few rules have been added since 2015.
Fixing the existing issues due to old audio code style (when
changing/moving code) is fine, but not required. Newly added code
should follow usual qemu code style.
cheers,
Gerd
- [Qemu-devel] [PATCH v3 00/50] Audio 5.1 patches, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 06/50] coreaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 08/50] noaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 03/50] audio: -audiodev command line option: documentation, Kővágó, Zoltán, 2019/01/16
- [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 09/50] ossaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 19/50] paaudio: do not move stream when sink/source name is specified, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 01/50] qapi: qapi for audio backends, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 13/50] wavaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 22/50] audio: do not run each backend in audio_run, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 10/50] paaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 07/50] dsoundaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 14/50] audio: -audiodev command line option: cleanup, Kővágó, Zoltán, 2019/01/16
[Qemu-devel] [PATCH v3 12/50] spiceaudio: port to -audiodev config, Kővágó, Zoltán, 2019/01/16