[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null",
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure |
Date: |
Mon, 28 Jan 2019 09:47:52 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.91 |
Philippe Mathieu-Daudé <address@hidden> writes:
> Previous to OpenBSD 6.3 [1], fcntl(F_SETFL) is not permitted on memory
> devices. Do not assert fcntl failures on OpenBSD.
> This fixes:
>
> $ lm32-softmmu/qemu-system-lm32
> assertion "f != -1" failed: file "util/oslib-posix.c", line 247, function
> "qemu_set_nonblock"
> Abort trap (core dumped)
>
> [1] The fix seems https://github.com/openbsd/src/commit/c2a35b387f9d3c
> "fcntl(F_SETFL) invokes the FIONBIO and FIOASYNC ioctls internally, so
> the memory devices (/dev/null, /dev/zero, etc) need to permit them."
I assume set_nonblock is called on more than just these special devices?
Is there anyway to check this on OpenBSD or is it just an anonymous fd
at this point?
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> util/oslib-posix.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 4ce1ba9ca4..064c3ae2f7 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -244,7 +244,9 @@ void qemu_set_nonblock(int fd)
> f = fcntl(fd, F_GETFL);
> assert(f != -1);
> f = fcntl(fd, F_SETFL, f | O_NONBLOCK);
> +#ifndef __OpenBSD__
> assert(f != -1);
> +#endif
> }
>
> int socket_set_fast_reuse(int fd)
--
Alex Bennée
- [Qemu-devel] [PATCH 0/3] OpenBSD fixes, Philippe Mathieu-Daudé, 2019/01/25
- [Qemu-devel] [PATCH 3/3] WIP tests/vm: Run tests on OpenBSD, Philippe Mathieu-Daudé, 2019/01/25
- [Qemu-devel] [PATCH 1/3] configure: Disable W^X on OpenBSD, Philippe Mathieu-Daudé, 2019/01/25
- [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure, Philippe Mathieu-Daudé, 2019/01/25
- Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure, Markus Armbruster, 2019/01/28
- Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure,
Alex Bennée <=
- Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure, Philippe Mathieu-Daudé, 2019/01/28
- Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure, Paolo Bonzini, 2019/01/28
- Re: [Qemu-devel] [PATCH 2/3] XXX oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure, Philippe Mathieu-Daudé, 2019/01/28