Re: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
dbc584d8e4 kconfig: introduce CONFIG_TEST_DEVICES
8152c3cdcd i386-softmmu.mak: remove all CONFIG_* except boards definitions
9125dc81b3 isa: express SuperIO dependencies with Kconfig
d5069fb84d tpm: express dependencies with Kconfig
95cedf00b5 virtio: express virtio dependencies with Kconfig
c08aa5bf58 vfio: express vfio dependencies with Kconfig
fd1c33aa2b hyperv: express dependencies with kconfig
113498fae7 display: express dependencies with kconfig
a8e13fa63b ptimer: express dependencies with Kconfig
a1bc5ac825 i2c: express dependencies with Kconfig
77fbb8a4f9 i386: express dependencies with Kconfig
15f86dff14 isa: express dependencies with kconfig
07a5dd70ec scsi: express dependencies with Kconfig
e3be0ba561 build: convert usb.mak to Kconfig
289f8ee6eb build: convert sound.mak to Kconfig
cc9459f304 build: convert pci.mak to Kconfig
e9e0f95878 hw/pci/Makefile.objs: make pcie configurable
cb484d2faa ide: express dependencies with Kconfig
34ef087788 minikconf: implement allnoconfig and defconfig
6d20af9496 build: switch to Kconfig
633d26b675 kconfig: introduce kconfig files
6894a6f9ac hw/display: make edid configurable
545dfba6e3 minikconfig: add semantic analysis
3f7644c209 minikconfig: add AST
019214c143 minikconfig: add parser skeleton
471f15950f hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core 
and PCI
f73711c181 hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and 
ACPI controller
6d368d08e3 hw/tricore/Makefile.objs: Create CONFIG_* for tricore
0ffeea9e1d hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc
3bb75e756c hw/moxie/Makefile.objs: Conditionally build moxie
9254086f91 hw/hppa/Makefile.objs: Create CONFIG_* for hppa
48afb37c92 hw/cris/Makefile.objs: Create CONFIG_* for cris
5e20c54774 hw/alpha/Makefile.objs: Create CONFIG_* for alpha
166db688d0 hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64
901c168998 hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards
dfad8241eb hw/nios2/Makefile.objs: Conditionally build nios2
18a4fba2fa hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga 
conditionally
7a747835ae hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst
d9c2d7c8c5 hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created
4f9987bbfa hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x 
boards and devices
dae7848cc4 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards 
and device
d89b1b3045 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*
18c42d91d1 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards
a6753004dc hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx 
boards
70e6a3881f hw/m68k/Makefile.objs: Conditionally build boards
89445f8a5c hw/arm/Makefile.objs: CONFIG_VIRT created for virt board
074cee383c hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards
562fe684db build: actually use CONFIG_PAM
af189a2289 hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS
144835aff2 vfio: move conditional up to hw/Makefile.objs
8318087cea ide: split ioport registration to a separate file
f0334c7173 arm: disable CONFIG_SERIAL_ISA

=== OUTPUT BEGIN ===
1/52 Checking commit f0334c717327 (arm: disable CONFIG_SERIAL_ISA)
2/52 Checking commit 8318087ceaae (ide: split ioport registration to a separate 
file)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#132: FILE: hw/ide/ioport.c:57:
+    /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA

WARNING: Block comments use * on subsequent lines
#133: FILE: hw/ide/ioport.c:58:
+    /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA
+       bridge has been setup properly to always register with ISA.  */

WARNING: Block comments use a trailing */ on a separate line
#133: FILE: hw/ide/ioport.c:58:
+       bridge has been setup properly to always register with ISA.  */

total: 0 errors, 4 warnings, 113 lines checked

Patch 2/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/52 Checking commit 144835aff233 (vfio: move conditional up to 
hw/Makefile.objs)
4/52 Checking commit af189a22894e (hw/pci-host/Makefile.objs: make CONFIGS 
clear for PCI EXPRESS)
5/52 Checking commit 562fe684db9d (build: actually use CONFIG_PAM)
6/52 Checking commit 074cee383cdd (hw/i386/Makefile.objs: Build pc_piix* and 
pc_q35 boards)
7/52 Checking commit 89445f8a5c91 (hw/arm/Makefile.objs: CONFIG_VIRT created 
for virt board)
8/52 Checking commit 70e6a3881fa2 (hw/m68k/Makefile.objs: Conditionally build 
boards)
9/52 Checking commit a6753004dcac (hw/microblaze/Makefile.objs: Create configs 
for petalogix and xilinx boards)
10/52 Checking commit 18c42d91d100 (hw/mips/Makefile.objs: Create CONFIG_* for 
r4k, malta, mipssim boards)
11/52 Checking commit d89b1b3045d9 (hw/ppc/Makefile.objs: Build all boards 
conditinally with CONFIG_*)
12/52 Checking commit dae7848cc4c2 (hw/sh4/Makefile.objs: New CONFIG_* 
varibales created for sh4 boards and device)
13/52 Checking commit 4f9987bbfa0f (hw/s390/Makefile.objs: Create new CONFIG_* 
variables for s390x boards and devices)
14/52 Checking commit d9c2d7c8c5b8 (hw/sparc/Makefile.objs: CONFIG_* for sun4m 
and leon3 created)
15/52 Checking commit 7a747835ae3a (hw/lm32/Makefile.objs: Conditionally build 
lm32 and milkmyst)
16/52 Checking commit 18a4fba2fae2 (hw/xtensa/Makefile.objs: Build xtensa_sim 
and xtensa_fpga conditionally)
17/52 Checking commit dfad8241eb23 (hw/nios2/Makefile.objs: Conditionally build 
nios2)
18/52 Checking commit 901c168998a7 (hw/riscv/Makefile.objs: Create CONFIG_* for 
riscv boards)
19/52 Checking commit 166db688d08e (hw/sparc64/Makefile.objs: Create CONFIG_* 
for sparc64)
20/52 Checking commit 5e20c547748d (hw/alpha/Makefile.objs: Create CONFIG_* for 
alpha)
21/52 Checking commit 48afb37c926a (hw/cris/Makefile.objs: Create CONFIG_* for 
cris)
22/52 Checking commit 9254086f9151 (hw/hppa/Makefile.objs: Create CONFIG_* for 
hppa)
23/52 Checking commit 3bb75e756cee (hw/moxie/Makefile.objs: Conditionally build 
moxie)
24/52 Checking commit 0ffeea9e1dd8 (hw/openrisc/Makefile.objs: Create CONFIG_* 
for openrisc)
25/52 Checking commit 6d368d08e36a (hw/tricore/Makefile.objs: Create CONFIG_* 
for tricore)
26/52 Checking commit f73711c18197 (hw/i2c/Makefile.objs: Create new CONFIG_* 
variables for EEPROM and ACPI controller)
27/52 Checking commit 471f15950f23 (hw/vfio/Makefile.objs: Create new CONFIG_* 
variables for VFIO core and PCI)
28/52 Checking commit 019214c143ad (minikconfig: add parser skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

WARNING: line over 80 characters
#251: FILE: scripts/minikconf.py:212:
+                           'Expected identifier starting with "CONFIG_"', 
TOK_NONE)

WARNING: line over 80 characters
#344: FILE: scripts/minikconf.py:305:
+            raise KconfigParserError(self, 'expected "source", "config", 
identifier, '

WARNING: line over 80 characters
#370: FILE: scripts/minikconf.py:331:
+            raise KconfigParserError(self, 'expected "source", "config" or 
identifier')

ERROR: line over 90 characters
#395: FILE: scripts/minikconf.py:356:
+        if self.src[self.cursor + length].isalnum() or self.src[self.cursor + 
length] == '|':

WARNING: line over 80 characters
#448: FILE: scripts/minikconf.py:409:
+            while self.src[self.cursor].isalnum() or self.src[self.cursor] == 
'_':

total: 1 errors, 5 warnings, 425 lines checked

Patch 28/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

29/52 Checking commit 3f7644c20919 (minikconfig: add AST)
WARNING: line over 80 characters
#89: FILE: scripts/minikconf.py:86:
+                return "config %s default %s if %s" % (self.dest, value, 
self.cond)

total: 0 errors, 1 warnings, 170 lines checked

Patch 29/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/52 Checking commit 545dfba6e34b (minikconfig: add semantic analysis)
WARNING: line over 80 characters
#112: FILE: scripts/minikconf.py:102:
+                raise Exception('contradiction between clauses when setting 
%s' % self)

WARNING: line over 80 characters
#215: FILE: scripts/minikconf.py:214:
+            debug_print(i, "->", [str(x) for x in 
self.referenced_vars[i].outgoing])

total: 0 errors, 2 warnings, 223 lines checked

Patch 30/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/52 Checking commit 6894a6f9ac98 (hw/display: make edid configurable)
32/52 Checking commit 633d26b67534 (kconfig: introduce kconfig files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#44: 
new file mode 100644

WARNING: line over 80 characters
#1762: FILE: scripts/minikconf.py:636:
+        print ("%s: at least one argument is required" % argv[0], 
file=sys.stderr)

total: 0 errors, 2 warnings, 1363 lines checked

Patch 32/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/52 Checking commit 6d20af9496e7 (build: switch to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#481: 
deleted file mode 100644

total: 0 errors, 1 warnings, 325 lines checked

Patch 33/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/52 Checking commit 34ef0877882f (minikconf: implement allnoconfig and 
defconfig)
35/52 Checking commit cb484d2faa02 (ide: express dependencies with Kconfig)
36/52 Checking commit e9e0f95878f9 (hw/pci/Makefile.objs: make pcie 
configurable)
37/52 Checking commit cc9459f304c7 (build: convert pci.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#120: 
deleted file mode 100644

total: 0 errors, 1 warnings, 472 lines checked

Patch 37/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
38/52 Checking commit 289f8ee6ebea (build: convert sound.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70: 
deleted file mode 100644

total: 0 errors, 1 warnings, 51 lines checked

Patch 38/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
39/52 Checking commit e3be0ba56197 (build: convert usb.mak to Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#158: 
deleted file mode 100644

total: 0 errors, 1 warnings, 157 lines checked

Patch 39/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/52 Checking commit 07a5dd70ec98 (scsi: express dependencies with Kconfig)
41/52 Checking commit 15f86dff14a3 (isa: express dependencies with kconfig)
42/52 Checking commit 77fbb8a4f9a3 (i386: express dependencies with Kconfig)
43/52 Checking commit a1bc5ac825b6 (i2c: express dependencies with Kconfig)
44/52 Checking commit a8e13fa63b07 (ptimer: express dependencies with Kconfig)
45/52 Checking commit 113498fae707 (display: express dependencies with kconfig)
46/52 Checking commit fd1c33aa2b65 (hyperv: express dependencies with kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
deleted file mode 100644

total: 0 errors, 1 warnings, 15 lines checked

Patch 46/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
47/52 Checking commit c08aa5bf58f4 (vfio: express vfio dependencies with 
Kconfig)
48/52 Checking commit 95cedf00b5f9 (virtio: express virtio dependencies with 
Kconfig)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
deleted file mode 100644

total: 0 errors, 1 warnings, 109 lines checked

Patch 48/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
49/52 Checking commit d5069fb84d2c (tpm: express dependencies with Kconfig)
50/52 Checking commit 9125dc81b384 (isa: express SuperIO dependencies with 
Kconfig)
51/52 Checking commit 8152c3cdcd36 (i386-softmmu.mak: remove all CONFIG_* 
except boards definitions)
52/52 Checking commit dbc584d8e473 (kconfig: introduce CONFIG_TEST_DEVICES)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden