Re: [Qemu-devel] [PATCH v10 00/24] Fixing record/replay and adding reverse debugging

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v10 00/24] Fixing record/replay and adding reverse 
debugging
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7049f80fc1 replay: rename step-related variables and functions
5eac81343e replay: fix replay shutdown
a747dc45e5 util/qemu-timer: refactor deadline calculation for external timers
5c5205178f replay: document development rules
b65f9e291f replay: init rtc after enabling the replay
a778d9ee8d replay: add BH oneshot event for block layer
d858309da1 replay: describe reverse debugging in docs/replay.txt
991916fcd5 gdbstub: add reverse continue support in replay mode
febeb64b34 gdbstub: add reverse step support in replay mode
bebb4134ef replay: flush rr queue before loading the vmstate
60699046ba replay: refine replay-time module
0972845ea5 replay: implement replay-seek command
34bf0280a3 replay: introduce breakpoint at the specified step
936ac99625 replay: introduce info hmp/qmp command
fb0fb9065e qapi: introduce replay.json for record/replay-related stuff
ceb76bedb5 replay: provide an accessor for rr filename
d6f41bb599 migration: introduce icount field for snapshots
5960b29c24 qcow2: introduce icount field for snapshots
70139c618c replay: finish record/replay before closing the disks
5e12f930b3 replay: don't drain/flush bdrv queue while RR is working
3b0e839a97 replay: update docs for record/replay with block devices
dc9eb62cc0 replay: disable default snapshot for record/replay
d89d015ba0 block: implement bdrv_snapshot_goto for blkreplay
10258d7cd0 replay: add missing fix for internal function

=== OUTPUT BEGIN ===
1/24 Checking commit 10258d7cd080 (replay: add missing fix for internal 
function)
2/24 Checking commit d89d015ba072 (block: implement bdrv_snapshot_goto for 
blkreplay)
3/24 Checking commit dc9eb62cc084 (replay: disable default snapshot for 
record/replay)
4/24 Checking commit 3b0e839a97dd (replay: update docs for record/replay with 
block devices)
5/24 Checking commit 5e12f930b330 (replay: don't drain/flush bdrv queue while 
RR is working)
6/24 Checking commit 70139c618c2c (replay: finish record/replay before closing 
the disks)
7/24 Checking commit 5960b29c24e4 (qcow2: introduce icount field for snapshots)
8/24 Checking commit d6f41bb59907 (migration: introduce icount field for 
snapshots)
9/24 Checking commit ceb76bedb566 (replay: provide an accessor for rr filename)
10/24 Checking commit fb0fb9065eef (qapi: introduce replay.json for 
record/replay-related stuff)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 78 lines checked

Patch 10/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/24 Checking commit 936ac996257c (replay: introduce info hmp/qmp command)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#142: 
new file mode 100644

total: 0 errors, 1 warnings, 127 lines checked

Patch 11/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/24 Checking commit 34bf0280a37e (replay: introduce breakpoint at the 
specified step)
13/24 Checking commit 0972845ea59e (replay: implement replay-seek command)
ERROR: "foo* bar" should be "foo *bar"
#118: FILE: replay/replay-debugging.c:134:
+                                          int64_t* snapshot_icount)

total: 1 errors, 0 warnings, 155 lines checked

Patch 13/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/24 Checking commit 60699046ba21 (replay: refine replay-time module)
15/24 Checking commit bebb4134ef18 (replay: flush rr queue before loading the 
vmstate)
16/24 Checking commit febeb64b34b3 (gdbstub: add reverse step support in replay 
mode)
17/24 Checking commit 991916fcd522 (gdbstub: add reverse continue support in 
replay mode)
18/24 Checking commit d858309da1bc (replay: describe reverse debugging in 
docs/replay.txt)
19/24 Checking commit a778d9ee8d3b (replay: add BH oneshot event for block 
layer)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#316: 
new file mode 100644

total: 0 errors, 1 warnings, 224 lines checked

Patch 19/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/24 Checking commit b65f9e291f15 (replay: init rtc after enabling the replay)
21/24 Checking commit 5c5205178f60 (replay: document development rules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

total: 0 errors, 1 warnings, 46 lines checked

Patch 21/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/24 Checking commit a747dc45e5bd (util/qemu-timer: refactor deadline 
calculation for external timers)
23/24 Checking commit 5eac81343e93 (replay: fix replay shutdown)
24/24 Checking commit 7049f80fc128 (replay: rename step-related variables and 
functions)
WARNING: line over 80 characters
#117: FILE: replay/replay-debugging.c:246:
+        replay_seek(replay_get_current_icount() - 1, replay_stop_vm_debug, 
&err);

total: 0 errors, 1 warnings, 282 lines checked

Patch 24/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden