[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics
From: |
Yuval Shaia |
Subject: |
Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters |
Date: |
Thu, 31 Jan 2019 22:08:17 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Jan 31, 2019 at 07:17:16AM -0600, Eric Blake wrote:
> On 1/31/19 7:08 AM, Yuval Shaia wrote:
> > Signed-off-by: Yuval Shaia <address@hidden>
> > ---
> > hmp-commands-info.hx | 14 ++++++++++++++
> > monitor.c | 6 ++++++
> > 2 files changed, 20 insertions(+)
Hi Eric,
>
> Commit message should state WHY this is being added as an HMP-only
> command, and does not have a QMP counterpart. It may be okay if the
> interface is only designed to be useful to developers, but having that
> justification in the git log is important.
Thanks for your review.
See, i need this interface mainly for development/debug purposes, to help
troubleshot problems and to give insights to what device "is doing".
Trace points are great but not effective in high load.
QMP as i see it, and correct me if i'm wrong, is used to report management
events etc and also here, is not effective in high load.
I choose this interface as it is interactive, i.e. whenever i need the info
i trigger 'info pvrdmastats' command from the monitor console.
During my research i notice that some devices (or families) have nice user
interface via virsh (blkstat, ifstat, memstat etc). Is it the preferred way
for non-devel/debug purposes?
If this is the correct method for this purpose then let me know and i'll
update the git log message accordingly.
Thanks.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>
- [Qemu-devel] [PATCH 00/10] Misc fixes to pvrdma device, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 02/10] hw/rdma: Introduce locked qlist, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 03/10] hw/rdma: Warn when too many consecutive poll CQ triggered on an empty CQ, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 05/10] hw/pvrdma: Add device statistics counters, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 04/10] hw/rdma: Protect against concurrent execution of poll_cq, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 01/10] hw/rdma: Switch to generic error reporting way, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 06/10] hw/pvrdma: Dump device statistics counters to file, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 08/10] hw/rdma: Free all MAD receive buffers when device is closed, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 09/10] hw/rdma: Free all receive buffers when QP is destroyed, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 10/10] hw/pvrdma: Delete unneeded function argument, Yuval Shaia, 2019/01/31