[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters |
|
Date: |
Thu, 31 Jan 2019 07:17:16 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/31/19 7:08 AM, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia <address@hidden>
> ---
> hmp-commands-info.hx | 14 ++++++++++++++
> monitor.c | 6 ++++++
> 2 files changed, 20 insertions(+)
Commit message should state WHY this is being added as an HMP-only
command, and does not have a QMP counterpart. It may be okay if the
interface is only designed to be useful to developers, but having that
justification in the git log is important.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/10] Misc fixes to pvrdma device, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 02/10] hw/rdma: Introduce locked qlist, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 03/10] hw/rdma: Warn when too many consecutive poll CQ triggered on an empty CQ, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 05/10] hw/pvrdma: Add device statistics counters, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 04/10] hw/rdma: Protect against concurrent execution of poll_cq, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters, Yuval Shaia, 2019/01/31
- Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters,
Eric Blake <=
- [Qemu-devel] [PATCH 01/10] hw/rdma: Switch to generic error reporting way, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 06/10] hw/pvrdma: Dump device statistics counters to file, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 08/10] hw/rdma: Free all MAD receive buffers when device is closed, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 09/10] hw/rdma: Free all receive buffers when QP is destroyed, Yuval Shaia, 2019/01/31
- [Qemu-devel] [PATCH 10/10] hw/pvrdma: Delete unneeded function argument, Yuval Shaia, 2019/01/31