[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 07/10] monitor: Expose pvrdma device statistics counters
Date: Thu, 31 Jan 2019 07:17:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/31/19 7:08 AM, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia <address@hidden>
> ---
>  hmp-commands-info.hx | 14 ++++++++++++++
>  monitor.c            |  6 ++++++
>  2 files changed, 20 insertions(+)

Commit message should state WHY this is being added as an HMP-only
command, and does not have a QMP counterpart.  It may be okay if the
interface is only designed to be useful to developers, but having that
justification in the git log is important.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]