[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] target/arm: Implement ARMv8.3-JSConv
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] target/arm: Implement ARMv8.3-JSConv |
|
Date: |
Mon, 4 Feb 2019 11:34:31 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/4/19 11:21 AM, Peter Maydell wrote:
> On Mon, 4 Feb 2019 at 10:17, Richard Henderson
> <address@hidden> wrote:
>>
>> On 2/4/19 8:00 AM, Laurent Desnogues wrote:
>>> The pseudo code asks for NaN inputs to return 0 since FPUnpack returns
>>> a value of 0 for NaN.
>>>
>>> The rest looks correct.
>>
>> So it does. I apparently copied the INT_MAX thing from softfloat.c without
>> double-checking.
>
> I'm a little surprised risu didn't catch that -- it's usually
> quite keen on checking NaN behaviour...
I'm not sure either... Because of other issues, I regenerated the .bin file
and the nan case does trigger now. I'm not sure what happened before.
r~
[Qemu-devel] [PATCH 1/3] target/arm: Force result size into dp after operation, Richard Henderson, 2019/02/04
[Qemu-devel] [PATCH 2/3] target/arm: Restructure disas_fp_int_conv, Richard Henderson, 2019/02/04
Re: [Qemu-devel] [PATCH 0/3] target/arm: Implement ARMv8.3-JSConv, no-reply, 2019/02/04
Re: [Qemu-devel] [PATCH 0/3] target/arm: Implement ARMv8.3-JSConv, Peter Maydell, 2019/02/04