[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig
Date: Tue, 26 Feb 2019 18:24:38 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Paolo Bonzini <address@hidden> writes:

> On 26/02/19 14:44, Markus Armbruster wrote:
>> Paolo Bonzini <address@hidden> writes:
>>> On 25/02/19 09:44, Stefano Garzarella wrote:
>>>>>  config I440FX
>>>>>      bool
>>>>> +    select PC_PCI
>>>>> +    select PC_ACPI
>>>>> +    select ACPI_SMBUS
>>>>> +    select PCI_PIIX
>>>>> +    select FDC
>>>> Should we move "select FDC" under "config PC"?
>>>> I'm not able to build the Q35 machine without enable FDC, since some fdc
>>>> functions are used in hw/i386/pc.c (eg. isa_fdc_get_drive_type())
>>> Yes, that's a good idea.  I mistakenly thought that Q35 could be built
>>> without FDC.
>> Could we add stubs to make it buildable that way?
> Of course I'm ecstatic that one benefit of Kconfig (finding suboptimal
> dependencies) is already being realized _before_ it lands, but not now.
>  However, those kind of cleanups can wait for 4.1. :)


> Note that we're doing the most important cleanups (e.g. not having to
> bring PCI into boards that don't need it), but overall this series will
> be about 120 patches and it's already a half miracle that everything was
> done in <2 months and it will be already in 4.0.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]