[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/19] arm:i2c: Don't mask return from i2c_recv()
From: |
minyard |
Subject: |
[Qemu-devel] [PULL 03/19] arm:i2c: Don't mask return from i2c_recv() |
Date: |
Thu, 28 Feb 2019 12:16:54 -0600 |
From: Corey Minyard <address@hidden>
It can't fail, and now that it returns a uint8_t a 0xff mask
is unnecessary.
Signed-off-by: Corey Minyard <address@hidden>
Suggested-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
hw/arm/stellaris.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
index 442529cc65..7b45fe3ccf 100644
--- a/hw/arm/stellaris.c
+++ b/hw/arm/stellaris.c
@@ -811,7 +811,7 @@ static void stellaris_i2c_write(void *opaque, hwaddr offset,
/* TODO: Handle errors. */
if (s->msa & 1) {
/* Recv */
- s->mdr = i2c_recv(s->bus) & 0xff;
+ s->mdr = i2c_recv(s->bus);
} else {
/* Send */
i2c_send(s->bus, s->mdr);
--
2.17.1
- [Qemu-devel] [PULL 00/19] Fix/add vmstate handling in some I2C code, minyard, 2019/02/28
- [Qemu-devel] [PULL 02/19] i2c: have I2C receive operation return uint8_t, minyard, 2019/02/28
- [Qemu-devel] [PULL 03/19] arm:i2c: Don't mask return from i2c_recv(),
minyard <=
- [Qemu-devel] [PULL 06/19] i2c:smbus: Simplify write operation, minyard, 2019/02/28
- [Qemu-devel] [PULL 15/19] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c, minyard, 2019/02/28
- [Qemu-devel] [PULL 18/19] i2c:smbus_eeprom: Add a reset function to smbus_eeprom, minyard, 2019/02/28
- [Qemu-devel] [PULL 01/19] i2c: Split smbus into parts, minyard, 2019/02/28
- [Qemu-devel] [PULL 17/19] i2c:smbus_eeprom: Add vmstate handling to the smbus eeprom, minyard, 2019/02/28
- [Qemu-devel] [PULL 04/19] i2c: Don't check return value from i2c_recv(), minyard, 2019/02/28
- [Qemu-devel] [PULL 11/19] i2c:pm_smbus: Fix pm_smbus handling of I2C block read, minyard, 2019/02/28
- [Qemu-devel] [PULL 10/19] boards.h: Ignore migration for SMBus devices on older machines, minyard, 2019/02/28
- [Qemu-devel] [PULL 09/19] i2c:smbus: Make white space in switch statements consistent, minyard, 2019/02/28
- [Qemu-devel] [PULL 16/19] i2c:smbus_eeprom: Add a size constant for the smbus_eeprom size, minyard, 2019/02/28