[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/19] i2c:smbus: Make white space in switch statemen
From: |
minyard |
Subject: |
[Qemu-devel] [PULL 09/19] i2c:smbus: Make white space in switch statements consistent |
Date: |
Thu, 28 Feb 2019 12:17:00 -0600 |
From: Corey Minyard <address@hidden>
It had spaces between cases in some places and not others. Add a space
for every one.
Signed-off-by: Corey Minyard <address@hidden>
---
hw/i2c/smbus_eeprom.c | 1 +
hw/i2c/smbus_slave.c | 9 +++++++++
2 files changed, 10 insertions(+)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index 2f90287b69..2816e35bcc 100644
--- a/hw/i2c/smbus_eeprom.c
+++ b/hw/i2c/smbus_eeprom.c
@@ -43,6 +43,7 @@ static uint8_t eeprom_receive_byte(SMBusDevice *dev)
SMBusEEPROMDevice *eeprom = (SMBusEEPROMDevice *) dev;
uint8_t *data = eeprom->data;
uint8_t val = data[eeprom->offset++];
+
#ifdef DEBUG
printf("eeprom_receive_byte: addr=0x%02x val=0x%02x\n",
dev->i2c.address, val);
diff --git a/hw/i2c/smbus_slave.c b/hw/i2c/smbus_slave.c
index 52a57423ee..5b3046f6a3 100644
--- a/hw/i2c/smbus_slave.c
+++ b/hw/i2c/smbus_slave.c
@@ -70,6 +70,7 @@ static int smbus_i2c_event(I2CSlave *s, enum i2c_event event)
DPRINTF("Incoming data\n");
dev->mode = SMBUS_WRITE_DATA;
break;
+
default:
BADF("Unexpected send start condition in state %d\n", dev->mode);
dev->mode = SMBUS_CONFUSED;
@@ -83,6 +84,7 @@ static int smbus_i2c_event(I2CSlave *s, enum i2c_event event)
DPRINTF("Read mode\n");
dev->mode = SMBUS_READ_DATA;
break;
+
case SMBUS_WRITE_DATA:
if (dev->data_len == 0) {
BADF("Read after write with no data\n");
@@ -93,6 +95,7 @@ static int smbus_i2c_event(I2CSlave *s, enum i2c_event event)
dev->mode = SMBUS_READ_DATA;
}
break;
+
default:
BADF("Unexpected recv start condition in state %d\n", dev->mode);
dev->mode = SMBUS_CONFUSED;
@@ -129,9 +132,11 @@ static int smbus_i2c_event(I2CSlave *s, enum i2c_event
event)
case SMBUS_DONE:
/* Nothing to do. */
break;
+
case SMBUS_READ_DATA:
dev->mode = SMBUS_DONE;
break;
+
default:
BADF("Unexpected NACK in state %d\n", dev->mode);
dev->mode = SMBUS_CONFUSED;
@@ -155,11 +160,13 @@ static uint8_t smbus_i2c_recv(I2CSlave *s)
}
DPRINTF("Read data %02x\n", ret);
break;
+
default:
BADF("Unexpected read in state %d\n", dev->mode);
dev->mode = SMBUS_CONFUSED;
break;
}
+
return ret;
}
@@ -176,10 +183,12 @@ static int smbus_i2c_send(I2CSlave *s, uint8_t data)
dev->data_buf[dev->data_len++] = data;
}
break;
+
default:
BADF("Unexpected write in state %d\n", dev->mode);
break;
}
+
return 0;
}
--
2.17.1
- [Qemu-devel] [PULL 02/19] i2c: have I2C receive operation return uint8_t, (continued)
- [Qemu-devel] [PULL 02/19] i2c: have I2C receive operation return uint8_t, minyard, 2019/02/28
- [Qemu-devel] [PULL 03/19] arm:i2c: Don't mask return from i2c_recv(), minyard, 2019/02/28
- [Qemu-devel] [PULL 06/19] i2c:smbus: Simplify write operation, minyard, 2019/02/28
- [Qemu-devel] [PULL 15/19] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c, minyard, 2019/02/28
- [Qemu-devel] [PULL 18/19] i2c:smbus_eeprom: Add a reset function to smbus_eeprom, minyard, 2019/02/28
- [Qemu-devel] [PULL 01/19] i2c: Split smbus into parts, minyard, 2019/02/28
- [Qemu-devel] [PULL 17/19] i2c:smbus_eeprom: Add vmstate handling to the smbus eeprom, minyard, 2019/02/28
- [Qemu-devel] [PULL 04/19] i2c: Don't check return value from i2c_recv(), minyard, 2019/02/28
- [Qemu-devel] [PULL 11/19] i2c:pm_smbus: Fix pm_smbus handling of I2C block read, minyard, 2019/02/28
- [Qemu-devel] [PULL 10/19] boards.h: Ignore migration for SMBus devices on older machines, minyard, 2019/02/28
- [Qemu-devel] [PULL 09/19] i2c:smbus: Make white space in switch statements consistent,
minyard <=
- [Qemu-devel] [PULL 16/19] i2c:smbus_eeprom: Add a size constant for the smbus_eeprom size, minyard, 2019/02/28
- [Qemu-devel] [PULL 05/19] i2c:smbus: Correct the working of quick commands, minyard, 2019/02/28
- [Qemu-devel] [PULL 07/19] i2c:smbus: Simplify read handling, minyard, 2019/02/28
- [Qemu-devel] [PULL 12/19] migration: Add a VMSTATE_BOOL_TEST() macro, minyard, 2019/02/28
- [Qemu-devel] [PULL 19/19] i2c: Verify that the count passed in to smbus_eeprom_init() is valid, minyard, 2019/02/28
- [Qemu-devel] [PULL 14/19] i2c:smbus_slave: Add an SMBus vmstate structure, minyard, 2019/02/28
- [Qemu-devel] [PULL 08/19] i2c:smbus_eeprom: Get rid of the quick command, minyard, 2019/02/28
- [Qemu-devel] [PULL 13/19] i2c:pm_smbus: Fix state transfer, minyard, 2019/02/28