Re: [Qemu-devel] [PATCH 2/3] make latency configurable

[Gerd Hoffmann]

  Hi,

>          r = pa_stream_connect_playback (stream, dev, attr,
>                                          PA_STREAM_INTERPOLATE_TIMING
> -#ifdef PA_STREAM_ADJUST_LATENCY
>                                          |PA_STREAM_ADJUST_LATENCY
> -#endif

Unrelated change, separate commit please.

Which pulse version added this define, and how old is it?
(should be answered in the commit message).

> -    /*
> -     * qemu audio tick runs at 100 Hz (by default), so processing
> -     * data chunks worth 10 ms of sound should be a good fit.
> -     */
> -    ba.tlength = pa_usec_to_bytes (10 * 1000, &ss);
> -    ba.minreq = pa_usec_to_bytes (5 * 1000, &ss);
> +    ba.tlength = pa_usec_to_bytes (ppdo->latency, &ss);
> +    ba.minreq = -1;

Please explain this in the commit message.

> -        pdo->buffer_length = dev->timer_period * 4;
> +        pdo->buffer_length = dev->timer_period * 9 / 2;

Likewise.

> +# @latency: latency you want PulseAudio to archieve in microseconds
> +#           (default 15000)

Is there a good reason to make this configurable?

cheers,
  Gerd