[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored
From: |
Martin Schrodt |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] fix: buffer_length is ignored |
Date: |
Fri, 15 Mar 2019 08:49:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 |
Hi,
On 3/15/19 8:43 AM, Gerd Hoffmann wrote:
> Hi,
>
>> - qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as, 46440);
>> + qapi_AudiodevPaPerDirectionOptions_base(ppdo), &obt_as,
>> ppdo->buffer_length);
>
> I'd just use
>
> ppdo->has_buffer_length ? ppdo->buffer_length : dev->timer_period * 4
>
> here.
>
> cheers,
> Gerd
>
>
I made sure the value is present via the new function
static int qpa_validate_per_direction_opts()
That way, I can group the setting of all defaults in a single place,
which is cleaner from my perspective.
Wouldn't you agree?
cheers,
Martin
Re: [Qemu-devel] [PATCH 0/3] Fixes for PulseAudio driver, no-reply, 2019/03/14