Re: [Qemu-devel] [PATCH v3] target/mips: Fix minor bug in FPU

[Peter Maydell]

On Tue, 19 Mar 2019 at 19:21, Aleksandar Markovic
<address@hidden> wrote:
>
> > From: Mateja Marjanovic <address@hidden>
> > Subject: [PATCH v3] target/mips: Fix minor bug in FPU
> >
> > From: Mateja Marjanovic <address@hidden>
> >
> > Wrong type of NaN was generated for IEEE 754-2008 by MADDF.<D|S> and
> > MSUBF.<D|S> instructions when the arguments were (inf, zero, nan) or
> > (zero, inf, nan).
> > These instructions were tested and the results match with the results
> > of the machine that has a MIPS64 r6 cpu.
> >
> > Signed-off-by: Mateja Marjanovic <address@hidden>
> > ---
>
> Mateja,
>
> The commit message is missing information on the reference source
> of information, that you placed in the cover letter. In my opinion, this is
> an important peace of information for anybody seeing and examining
> this patch in future, so please submit a new version of the patch as an
> isolated patch and updated commit message.

If Alex is willing to edit the commit message in his tree
that would save Mateja from having to do another respin.

thanks
-- PMM