Re: [Qemu-devel] [PATCH for 4.1 v2 09/13] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

[Laszlo Ersek]

On 03/26/19 15:19, Laszlo Ersek wrote:
> On 03/26/19 14:09, Igor Mammedov wrote:
>> once FW provides a pointer to SMBIOS entry point like it does for
>> RSDP it should be possible to enable this one the same way.
>>
>> Signed-off-by: Igor Mammedov <address@hidden>
>> ---
>>  tests/bios-tables-test.c | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
>> index 91846d6..097ef03 100644
>> --- a/tests/bios-tables-test.c
>> +++ b/tests/bios-tables-test.c
>> @@ -569,8 +569,11 @@ static void test_acpi_one(const char *params, test_data 
>> *data)
>>          }
>>      }
>>  
>> -    test_smbios_entry_point(data);
>> -    test_smbios_structs(data);
>> +    /* TODO: make SMBIOS tests work with UEFI firmware */
>> +    if (!use_uefi) {
>> +        test_smbios_entry_point(data);
>> +        test_smbios_structs(data);
>> +    }
>>  
>>      assert(!global_qtest);
>>      qtest_quit(data->qts);
>>
> 
> For now:
> 
> Reviewed-by: Laszlo Ersek <address@hidden>
> 
> Can you file a LP item about this, and assign it to me? (I can assign it
> to myself as well if you send me the link.)

To clarify, I'm offering to extend the UEFI helper app under
"tests/uefi-test-tools/UefiTestToolsPkg", in order to expose two new
entry point fields (one for SMBIOS 2 and another for SMBIOS 3). I'll
leave the qtest code refresh to you :)

Laszlo

> ... In fact, if we have a LP ticket, we could reference it either in the
> code comment, or in the commit message. I'll leave that up to you (you
> can keep my R-b either way).
> 
> Thanks,
> Laszlo
>