[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/5] 9p: mitigates most QID path collisions
From: |
Christian Schoenebeck |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/5] 9p: mitigates most QID path collisions |
Date: |
Tue, 07 May 2019 15:11:26 +0200 |
On Dienstag, 7. Mai 2019 13:42:47 CEST Daniel P. Berrangé wrote:
> > This first patch here is an updated version of Antonios Motakis'
> > original 4-patch set (using fixed length 16 bit prefixes), merged to one
> > patch:
> >
> > https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02283.html
> >
> > * Updated to latest git master, specifically to new qht interface.
> >
> > * Merged the original 4 patches to this single patch.
>
> Why did you merge them all into one ? The split patches were "best
> practice" IMHO. The original patch authorship & S-o-B lines could
> be preserved if you kept them split as before too.
Seems I misinterpreted an old comment of Greg that he would like to see them
to be merged into less patches. I think it was this one:
https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02590.html
No problem, I will restore Antonios' original individual 4 patches
appropriately. What about SOB then? Should I just place Antonio's SOB on those
4 patches or does it need his and mine SOB lines? (I mean I need to rebase
those 4 patches and address the old issues on them)
Best regards,
Christian Schoenebeck
[Qemu-devel] [PATCH v3 2/5] 9P: trivial cleanup of QID path collision mitigation, Christian Schoenebeck, 2019/05/06
[Qemu-devel] [PATCH v3 4/5] 9p: use variable length suffixes for inode mapping, Christian Schoenebeck, 2019/05/06
[Qemu-devel] [PATCH v3 1/5] 9p: mitigates most QID path collisions, Christian Schoenebeck, 2019/05/06
[Qemu-devel] [PATCH v3 3/5] 9p: persistency of QID path beyond reboots / suspensions, Christian Schoenebeck, 2019/05/06