Re: [Qemu-devel] [PATCH v3 1/5] 9p: mitigates most QID path collisions

[Daniel P . Berrangé]

On Tue, May 07, 2019 at 03:11:26PM +0200, Christian Schoenebeck wrote:
> On Dienstag, 7. Mai 2019 13:42:47 CEST Daniel P. Berrangé wrote:
> > > This first patch here is an updated version of Antonios Motakis'
> > > original 4-patch set (using fixed length 16 bit prefixes), merged to one
> > > patch:
> > > 
> > > https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02283.html
> > > 
> > > * Updated to latest git master, specifically to new qht interface.
> > > 
> > > * Merged the original 4 patches to this single patch.
> > 
> > Why did you merge them all into one ?  The split patches were "best
> > practice" IMHO. The original patch authorship & S-o-B lines could
> > be preserved if you kept them split as before too.
> 
> Seems I misinterpreted an old comment of Greg that he would like to see them 
> to be merged into less patches. I think it was this one:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2018-02/msg02590.html
> 
> No problem, I will restore Antonios' original individual 4 patches 
> appropriately. What about SOB then? Should I just place Antonio's SOB on 
> those 
> 4 patches or does it need his and mine SOB lines? (I mean I need to rebase 
> those 4 patches and address the old issues on them)

If the patch is unchanged from Antonio's original then it only needs to
have Antonio's SOB. If you have modified the patch yourself, then you
would add your own SOB, in addition to Antonio's original SOB. 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|