Re: [Qemu-devel] [PATCH v3 38/39] tcg/arm: Use LDRD to load tlb mask+table

[Alistair Francis]

On Sat, May 11, 2019 at 12:13 PM Richard Henderson
<address@hidden> wrote:
>
> On 5/10/19 2:08 PM, Alistair Francis wrote:
> >> +        if (use_armv6_instructions && TARGET_LONG_BITS == 64) {
> >> +            tcg_out_ldrd_8(s, COND_AL, TCG_REG_R2, TCG_REG_R1, cmp_off);
> ...
> >
> > This is complex and I'm probably misunderstanding something but isn't
> > it possible for TCG_REG_R3 to not be set if use_armv6_instructions is
> > true and TARGET_LONG_BITS is 64?
>
> No, the LDRD instruction loads data into both R2 and R2+1 = R3.

Ah ok. This looks fine to me then but I don't think I fully grasp it
enough to Ack it.

Alistair

>
>
> r~