[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver
From: |
Pankaj Gupta |
Subject: |
Re: [Qemu-devel] [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver |
Date: |
Tue, 14 May 2019 06:02:48 -0400 (EDT) |
> >>
> >> I think you should do the same here, vdev->priv is allocated in
> >> virtio_pmem_probe.
> >>
> >> But maybe I am missing something important here :)
> >
> > Because virtio_balloon use "kzalloc" for allocation and needs to be freed.
> > But virtio pmem uses "devm_kzalloc" which takes care of automatically
> > deleting
> > the device memory when associated device is detached.
>
> Hehe, thanks, that was the part that I was missing!
Thank you for the review.
Best regards,
Pankaj
>
> --
>
> Thanks,
>
> David / dhildenb
>
[Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Dan Williams, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Dan Williams, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/10
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/13
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Dan Williams, 2019/05/13
- Re: [Qemu-devel] [PATCH v8 3/6] libnvdimm: add dax_dev sync flag, Pankaj Gupta, 2019/05/14
[Qemu-devel] [PATCH v8 4/6] dax: check synchronous mapping is supported, Pankaj Gupta, 2019/05/10
[Qemu-devel] [PATCH v8 5/6] ext4: disable map_sync for async flush, Pankaj Gupta, 2019/05/10