[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with n
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with new infra |
Date: |
Wed, 15 May 2019 17:55:33 +0100 |
User-agent: |
mu4e 1.3.1; emacs 26.1 |
Jon Doron <address@hidden> writes:
> Signed-off-by: Jon Doron <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> gdbstub.c | 25 +++++++++++++++++++------
> 1 file changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 9fe130f30d..9b0556f8be 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1805,6 +1805,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx,
> void *user_ctx)
> gdb_continue(gdb_ctx->s);
> }
>
> +static void handle_step(GdbCmdContext *gdb_ctx, void *user_ctx)
> +{
> + if (gdb_ctx->num_params) {
> + gdb_set_cpu_pc(gdb_ctx->s, (target_ulong)gdb_ctx->params[0].val_ull);
> + }
> +
> + cpu_single_step(gdb_ctx->s->c_cpu, sstep_flags);
> + gdb_continue(gdb_ctx->s);
> +}
> +
> static int gdb_handle_packet(GDBState *s, const char *line_buf)
> {
> CPUState *cpu;
> @@ -1937,13 +1947,16 @@ static int gdb_handle_packet(GDBState *s, const char
> *line_buf)
> }
> break;
> case 's':
> - if (*p != '\0') {
> - addr = strtoull(p, (char **)&p, 16);
> - gdb_set_cpu_pc(s, addr);
> + {
> + static const GdbCmdParseEntry step_cmd_desc = {
> + .handler = handle_step,
> + .cmd = "s",
> + .cmd_startswith = 1,
> + .schema = "L0"
> + };
> + cmd_parser = &step_cmd_desc;
> }
> - cpu_single_step(s->c_cpu, sstep_flags);
> - gdb_continue(s);
> - return RS_IDLE;
> + break;
> case 'F':
> {
> static const GdbCmdParseEntry file_io_cmd_desc = {
--
Alex Bennée
- Re: [Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported, (continued)
- [Qemu-devel] [PATCH v9 07/27] gdbstub: Implement insert breakpoint (Z pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 20/27] gdbstub: Implement target halted (? pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 12/27] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with new infra, Jon Doron, 2019/05/02
- Re: [Qemu-devel] [PATCH v9 16/27] gdbstub: Implement step (s pkt) with new infra,
Alex Bennée <=
- [Qemu-devel] [PATCH v9 08/27] gdbstub: Implement remove breakpoint (z pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 11/27] gdbstub: Implement write memory (M pkt) with new infra, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 23/27] gdbstub: Implement qemu physical memory mode, Jon Doron, 2019/05/02
- [Qemu-devel] [PATCH v9 26/27] gdbstub: Add support to read a MSR for KVM target, Jon Doron, 2019/05/02