Re: [Qemu-devel] [PATCH v9 22/27] gdbstub: Implement generic query qemu.Supported

[Jon Doron]

I suggest then that I'll squash this commit into the commit that
refactors the the Q/q packets and will add the required documentation
about this
in the commit message.

Do you agree?
-- Jon.

On Wed, May 15, 2019 at 8:41 PM Alex Bennée <address@hidden> wrote:
>
>
> Jon Doron <address@hidden> writes:
>
> > qemu.Supported query reply back with the supported qemu query/set
> > commands (commands are seperated with a semicolon from each other).
> >
> > gdb> maint packet qqemu.Supported
> >
> > Signed-off-by: Jon Doron <address@hidden>
> > ---
> >  gdbstub.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/gdbstub.c b/gdbstub.c
> > index 8bdfae4b29..00c07d6ec0 100644
> > --- a/gdbstub.c
> > +++ b/gdbstub.c
> > @@ -2127,6 +2127,11 @@ static void handle_query_attached(GdbCmdContext 
> > *gdb_ctx, void *user_ctx)
> >      put_packet(gdb_ctx->s, GDB_ATTACHED);
> >  }
> >
> > +static void handle_query_qemu_supported(GdbCmdContext *gdb_ctx, void 
> > *user_ctx)
> > +{
> > +    put_packet(gdb_ctx->s, "sstepbits;sstep");
>
> To maintain bisectability this response should be extended as each
> feature is added.
>
> > +}
> > +
> >  static GdbCmdParseEntry gdb_gen_query_set_common_table[] = {
> >      /* Order is important if has same prefix */
> >      {
> > @@ -2203,6 +2208,10 @@ static GdbCmdParseEntry gdb_gen_query_table[] = {
> >          .handler = handle_query_attached,
> >          .cmd = "Attached",
> >      },
> > +    {
> > +        .handler = handle_query_qemu_supported,
> > +        .cmd = "qemu.Supported",
> > +    },
> >  };
> >
> >  static void handle_gen_query(GdbCmdContext *gdb_ctx, void *user_ctx)
>
>
> --
> Alex Bennée