[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 17/25] aspeed/scu: Use qemu_guest_getrandom_nofai
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v8 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail |
Date: |
Thu, 16 May 2019 19:39:16 -0700 |
The random number is intended for use by the guest. As such, we should
honor the -seed argument for reproducibility. Use the *_nofail routine
instead of rolling our own error handling locally.
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Reviewed-by: Joel Stanley <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
hw/misc/aspeed_scu.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c
index c8217740ef..ab1e18ed4b 100644
--- a/hw/misc/aspeed_scu.c
+++ b/hw/misc/aspeed_scu.c
@@ -16,7 +16,7 @@
#include "qapi/visitor.h"
#include "qemu/bitops.h"
#include "qemu/log.h"
-#include "crypto/random.h"
+#include "qemu/guest-random.h"
#include "trace.h"
#define TO_REG(offset) ((offset) >> 2)
@@ -157,14 +157,8 @@ static const uint32_t
ast2500_a1_resets[ASPEED_SCU_NR_REGS] = {
static uint32_t aspeed_scu_get_random(void)
{
- Error *err = NULL;
uint32_t num;
-
- if (qcrypto_random_bytes((uint8_t *)&num, sizeof(num), &err)) {
- error_report_err(err);
- exit(1);
- }
-
+ qemu_guest_getrandom_nofail(&num, sizeof(num));
return num;
}
--
2.17.1
- [Qemu-devel] [PATCH v8 06/25] crypto: Use getrandom for qcrypto_random_bytes, (continued)
- [Qemu-devel] [PATCH v8 06/25] crypto: Use getrandom for qcrypto_random_bytes, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 08/25] ui/vnc: Split out authentication_failed, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 09/25] ui/vnc: Use gcrypto_random_bytes for start_auth_vnc, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 10/25] util: Add qemu_guest_getrandom and associated routines, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 11/25] cpus: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 12/25] linux-user: Initialize pseudo-random seeds for all guest cpus, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 14/25] linux-user: Use qemu_guest_getrandom_nofail for AT_RANDOM, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 13/25] linux-user: Call qcrypto_init if not using -seed, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 16/25] linux-user: Remove srand call, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail,
Richard Henderson <=
- [Qemu-devel] [PATCH v8 18/25] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 22/25] target/arm: Implement ARMv8.5-RNG, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 24/25] target/ppc: Use qemu_guest_getrandom for DARN, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 25/25] target/i386: Implement CPUID_EXT_RDRAND, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 23/25] target/ppc: Use gen_io_start/end around DARN, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 21/25] target/arm: Put all PAC keys into a structure, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 19/25] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom, Richard Henderson, 2019/05/16
- Re: [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc, Daniel P . Berrangé, 2019/05/22