[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc |
Date: |
Wed, 22 May 2019 11:58:07 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Thu, May 16, 2019 at 07:38:59PM -0700, Richard Henderson wrote:
> The change in v8 is to which objects are linked in to user-only
> from the crypto directory. Daniel asked for all of crypto-obj-y
> to be added, but I have been unable to find a solution that works.
>
> If I add crypto-obj-y, then authz-obj-y must be included to resolve
> dependencies. Daniel suggested splitting authz-obj-y into two, so
> that linux-user plus some of the tools need not link against libpam.
>
> However, I tried that, and in the process managed to break testing.
> I'm not really sure what I did wrong:
>
> TEST check-speed: tests/benchmark-crypto-cipher
> ERROR - too few tests run (expected 32, got 0)
>
> Or maybe it was broken before, but at least this way I'm not touching
> any of the variables that affect tests/Makefile.include.
>
> Given that user-only *is* being linked against the enabled crypto libs,
> the behaviour between static and non-static is identical, which is I
> believe the major portion of Daniel's request. I think further cleanup
> to the makefiles can be done separately.
>
For avoidance of any doubt
Acked-by: Daniel P. Berrangé <address@hidden>
for Richard to send a pull request with any of the crypto related patches
I'm tagged as maintainer for.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v8 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, (continued)
- [Qemu-devel] [PATCH v8 15/25] linux-user/aarch64: Use qemu_guest_getrandom for PAUTH keys, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 17/25] aspeed/scu: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 18/25] hw/misc/nrf51_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 22/25] target/arm: Implement ARMv8.5-RNG, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 24/25] target/ppc: Use qemu_guest_getrandom for DARN, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 25/25] target/i386: Implement CPUID_EXT_RDRAND, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 23/25] target/ppc: Use gen_io_start/end around DARN, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 21/25] target/arm: Put all PAC keys into a structure, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 19/25] hw/misc/bcm2835_rng: Use qemu_guest_getrandom_nofail, Richard Henderson, 2019/05/16
- [Qemu-devel] [PATCH v8 20/25] hw/misc/exynos4210_rng: Use qemu_guest_getrandom, Richard Henderson, 2019/05/16
- Re: [Qemu-devel] [PATCH v8 00/25] Add qemu_getrandom and ARMv8.5-RNG etc,
Daniel P . Berrangé <=